Bug 1380442
Summary: | Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Carl George <carl> |
Component: | Package Review | Assignee: | Benjamin Lefoul <lef> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dennis.schridde, fedora, fredrik, jistone, lef, package-review, samspam |
Target Milestone: | --- | Flags: | lef:
fedora-review?
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | BuildFails | ||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-02-26 00:40:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Carl George
2016-09-29 15:29:21 UTC
My goal is to add this package to F24+ and EPEL7. The build requirement of cargo is already in F24/F25/rawhide, but is still in testing for EPEL7. Hopefully by the time this review is done it will have moved to stable. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-88fc43e690 Cargo is now in EPEL7 stable, so that isn't a blocker anymore. Benjamin, can you provide more details about setting "Whiteboard: BuildFails"? Hello Carl, Have a look at this: http://koji.fedoraproject.org/koji/taskinfo?taskID=16072474 "BuildError: error building package (arch x86_64), mock exited with status 1; see build.log for more information" The x86_64 build appeared to fail with a transient network error, that one should be fine to do over. > + cargo build --release > Updating registry `https://github.com/rust-lang/crates.io-index` > warning: spurious network error (2 tries remaining): [12/-1] Failed to resolve > address for github.com: Temporary failure in name resolution The ppc64{,le} failures are more interesting. They don't see the cargo package at all. I checked the cargo spec file, and turns out it is has ExclusiveArch set. > ExclusiveArch: x86_64 i686 armv7hl aarch64 I'll add the same to my spec file. The latest cargo build for EPEL7 is only for x86_64, and the latest cargo build for F24/F25 is only for x86_64, i686, and armv7hl. I'll set an appropriate conditional. Please have another look. I also refreshed it to the latest upstream version. https://carlgeorge.fedorapeople.org/ripgrep/ripgrep.spec https://carlgeorge.fedorapeople.org/ripgrep/ripgrep-0.2.3-1.el7.centos.src.rpm I just did a scratch build myself, and got the same network error again. I guess the koji mock chroots don't have networking (reproducible builds?). I'm not sure if cargo has an option to build without using the network. I'll research it a bit more. I don't have any experience building with cargo, but I found this: https://czanik.blogs.balabit.com/2016/07/how-to-package-rust-applications-to-rpm-using-vendoring/ We're still working on packaging guidelines for rust/cargo. It's not that trivial and can be targeted only for cargo > 0.13 (In reply to Igor Gnatenko from comment #8) > We're still working on packaging guidelines for rust/cargo. Thanks Igor. Where can we follow the discussions on packaging guidelines for rust/cargo? Any way to automate a notification here when a consensus is reached? > It's not that trivial and can be targeted only for cargo > 0.13 So far cargo is > 0.13 only in rawhide. (In reply to Benjamin Lefoul from comment #9) > (In reply to Igor Gnatenko from comment #8) > > We're still working on packaging guidelines for rust/cargo. > > Thanks Igor. Where can we follow the discussions on packaging guidelines for > rust/cargo? Any way to automate a notification here when a consensus is > reached? We discussed it last friday on #fedora-rust. We will send some notification to devel@ ML once we will have something working. (In reply to Benjamin Lefoul from comment #9) > So far cargo is > 0.13 only in rawhide. It's = 0.13 actually. Hi, When you have some free time take a look at my spec file with bash, fish and zsh completion. Spec URL: https://raw.githubusercontent.com/fszymanski/specfiles/master/ripgrep/ripgrep.spec Copr: fszymanski/ripgrep We (Rust SIG), finally packaged ripgrep properly. https://lists.fedoraproject.org/archives/list/rust@lists.fedoraproject.org/message/P2ZGCET4HRIQS7CJ7PQSQMLA3MQIRIDL/ Unfortunately, it's not going to be earlier than F27, because our packaging methods require features in rpm/libsolv/dnf which will be only on newer version. However, we maintain our repo on fedorapeople.. Feel free to join our ML (rust.org) or IRC (#fedora-rust) and don't hesitate to ask questions. I tend to close this bug as WONTFIX at this point.. If you think otherwise, write your opinion. |