Bug 1380442 - Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep
Summary: Review Request: ripgrep - A search tool that combines the usability of ag wit...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: BuildFails
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-29 15:29 UTC by Carl George 🤠
Modified: 2026-03-05 23:34 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-26 00:40:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Carl George 🤠 2016-09-29 15:29:21 UTC
Spec URL: https://carlgeorge.fedorapeople.org/ripgrep/ripgrep.spec
SRPM URL: https://carlgeorge.fedorapeople.org/ripgrep/ripgrep-0.2.1-1.el7.src.rpm

Description:
ripgrep is a command line search tool that combines the usability of The Silver
Searcher (an ack clone) with the raw speed of GNU grep. ripgrep is fast, cross
platform, and written in Rust.

Fedora Account System Username: carlgeorge

Comment 1 Carl George 🤠 2016-09-29 15:48:02 UTC
My goal is to add this package to F24+ and EPEL7.  The build requirement of cargo is already in F24/F25/rawhide, but is still in testing for EPEL7.  Hopefully by the time this review is done it will have moved to stable.

https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-88fc43e690

Comment 2 Carl George 🤠 2016-10-12 21:23:16 UTC
Cargo is now in EPEL7 stable, so that isn't a blocker anymore.

Persona non grata, can you provide more details about setting "Whiteboard: BuildFails"?

Comment 3 Persona non grata 2016-10-13 06:40:28 UTC Comment hidden (spam)
Comment 4 Carl George 🤠 2016-10-13 21:15:52 UTC
The x86_64 build appeared to fail with a transient network error, that one should be fine to do over.

> + cargo build --release
>     Updating registry `https://github.com/rust-lang/crates.io-index`
> warning: spurious network error (2 tries remaining): [12/-1] Failed to resolve > address for github.com: Temporary failure in name resolution

The ppc64{,le} failures are more interesting.  They don't see the cargo package at all.  I checked the cargo spec file, and turns out it is has ExclusiveArch set.

> ExclusiveArch:  x86_64 i686 armv7hl aarch64

I'll add the same to my spec file.  The latest cargo build for EPEL7 is only for x86_64, and the latest cargo build for F24/F25 is only for x86_64, i686, and armv7hl.  I'll set an appropriate conditional.

Comment 5 Carl George 🤠 2016-10-13 21:59:35 UTC
Please have another look.  I also refreshed it to the latest upstream version.

https://carlgeorge.fedorapeople.org/ripgrep/ripgrep.spec
https://carlgeorge.fedorapeople.org/ripgrep/ripgrep-0.2.3-1.el7.centos.src.rpm

Comment 6 Carl George 🤠 2016-10-13 22:15:44 UTC
I just did a scratch build myself, and got the same network error again.  I guess the koji mock chroots don't have networking (reproducible builds?).  I'm not sure if cargo has an option to build without using the network.  I'll research it a bit more.

Comment 7 Persona non grata 2016-10-14 07:13:43 UTC Comment hidden (spam)
Comment 8 Igor Gnatenko 2016-10-14 07:41:40 UTC
We're still working on packaging guidelines for rust/cargo. It's not that trivial and can be targeted only for cargo > 0.13

Comment 9 Persona non grata 2016-10-14 08:11:12 UTC Comment hidden (spam)
Comment 10 Igor Gnatenko 2016-10-14 08:13:09 UTC
(In reply to Persona non grata from comment #9)
> (In reply to Igor Gnatenko from comment #8)
> > We're still working on packaging guidelines for rust/cargo. 
> 
> Thanks Igor. Where can we follow the discussions on packaging guidelines for
> rust/cargo? Any way to automate a notification here when a consensus is
> reached?
We discussed it last friday on #fedora-rust. We will send some notification to devel@ ML once we will have something working.

Comment 11 Persona non grata 2016-10-14 08:13:45 UTC Comment hidden (spam)
Comment 12 fszymanski 2016-12-25 15:12:53 UTC
Hi,

When you have some free time take a look at my spec file with bash, fish and zsh completion.

Spec URL: https://raw.githubusercontent.com/fszymanski/specfiles/master/ripgrep/ripgrep.spec

Copr: fszymanski/ripgrep

Comment 13 Igor Gnatenko 2017-02-26 00:37:01 UTC
We (Rust SIG), finally packaged ripgrep properly.

https://lists.fedoraproject.org/archives/list/rust@lists.fedoraproject.org/message/P2ZGCET4HRIQS7CJ7PQSQMLA3MQIRIDL/

Unfortunately, it's not going to be earlier than F27, because our packaging methods require features in rpm/libsolv/dnf which will be only on newer version. However, we maintain our repo on fedorapeople..

Feel free to join our ML (rust.org) or IRC (#fedora-rust) and don't hesitate to ask questions.

I tend to close this bug as WONTFIX at this point.. If you think otherwise, write your opinion.


Note You need to log in before you can comment on or make changes to this bug.