Bug 1382922

Summary:	Review Request: perl-WWW-Form-UrlEncoded - Parser and builder for application/x-www-form-urlencoded
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-31 07:35:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1382923, 1382928

Description Ralf Corsepius 2016-10-08 11:32:51 UTC

Spec URL: https://corsepiu.fedorapeople.org/packages/perl-WWW-Form-UrlEncoded.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-WWW-Form-UrlEncoded-0.23-1.fc26.src.rpm
Description: 
WWW::Form::UrlEncoded provides application/x-www-form-urlencoded parser and
builder. This module aims to have compatibility with other CPAN modules
like HTTP::Body's urlencoded parser.
Fedora Account System Username: corsepiu

Comment 1 Petr Pisar 2016-10-21 08:32:13 UTC

URL and Source0 addresses are usable. Ok.
Source0 archive is original (SHA-256: c87de2c895cf8a526bf5d3a231e6ca0e6d4cfdca72f8840b3fb039dbde478852). Ok.
The WWW-Form-UrlEncoded-0.23-arch.patch patch is good. Ok.
Summary verified from README.md. Ok.
Description verified from README.md. Ok.
License verified from lib/WWW/Form/UrlEncoded/PP.pm, lib/WWW/Form/UrlEncoded.pm, README.md, and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require `perl(File::Copy)' (Build.PL:54).
FIX: Build-require `perl(base)' (builder/MyBuilder.pm:5).
FIX: Build-require `perl(File::Path)' (builder/MyBuilder.pm:7).
FIX: Build-require `perl(bytes)' (lib/WWW/Form/UrlEncoded/PP.pm:109).

WWW::Form::UrlEncoded::XS is optional. Ok.
All tests pass. Ok.

$ rpmlint perl-WWW-Form-UrlEncoded.spec ../SRPMS/perl-WWW-Form-UrlEncoded-0.23-1.fc26.src.rpm ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Oct 21 10:23 /usr/share/doc/perl-WWW-Form-UrlEncoded
-rw-r--r--    1 root    root                     1239 Nov 19  2015 /usr/share/doc/perl-WWW-Form-UrlEncoded/Changes
-rw-r--r--    1 root    root                     4408 Nov 19  2015 /usr/share/doc/perl-WWW-Form-UrlEncoded/README.md
drwxr-xr-x    2 root    root                        0 Oct 21 10:23 /usr/share/licenses/perl-WWW-Form-UrlEncoded
-rw-r--r--    1 root    root                    18418 Nov 19  2015 /usr/share/licenses/perl-WWW-Form-UrlEncoded/LICENSE
-rw-r--r--    1 root    root                     3647 Oct 21 10:23 /usr/share/man/man3/WWW::Form::UrlEncoded.3pm.gz
-rw-r--r--    1 root    root                     2125 Oct 21 10:23 /usr/share/man/man3/WWW::Form::UrlEncoded::PP.3pm.gz
drwxr-xr-x    2 root    root                        0 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW
drwxr-xr-x    2 root    root                        0 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW/Form
drwxr-xr-x    2 root    root                        0 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW/Form/UrlEncoded
-rw-r--r--    1 root    root                     5091 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW/Form/UrlEncoded.pm
-rw-r--r--    1 root    root                     3942 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW/Form/UrlEncoded/PP.pm
File permissions and layout is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm | sort -f | uniq -c 
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.8.1
      1 perl(base)
      1 perl(bytes)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm | sort -f | uniq -c 
      1 perl(WWW::Form::UrlEncoded) = 0.23
      1 perl(WWW::Form::UrlEncoded::PP)
      1 perl-WWW-Form-UrlEncoded = 0.23-1.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm 
Binary dependencies resolvable. Ok.

Package build in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16148067). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items and provides an updated spec files.
Resolution: Package NOT approved.

Comment 2 Ralf Corsepius 2016-10-23 15:52:27 UTC

Updated version:
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-WWW-Form-UrlEncoded.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-WWW-Form-UrlEncoded-0.23-2.fc26.src.rpm

Comment 3 Petr Pisar 2016-10-24 12:11:32 UTC

Spec file changes:

--- perl-WWW-Form-UrlEncoded.spec.old   2016-10-08 13:26:44.000000000 +0200
+++ perl-WWW-Form-UrlEncoded.spec       2016-10-23 17:49:39.000000000 +0200
@@ -1,6 +1,6 @@
 Name:           perl-WWW-Form-UrlEncoded
 Version:        0.23
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Parser and builder for application/x-www-form-urlencoded
 License:        GPL+ or Artistic
 URL:            http://search.cpan.org/dist/WWW-Form-UrlEncoded/
@@ -13,15 +13,20 @@
 
 BuildRequires:  perl-generators
 BuildRequires:  perl >= 0:5.008001
+
 BuildRequires:  perl(Exporter)
+BuildRequires:  perl(File::Basename)
+BuildRequires:  perl(File::Copy)
+BuildRequires:  perl(File::Spec)
 BuildRequires:  perl(JSON) >= 2
 BuildRequires:  perl(Module::Build) > 0.38
 BuildRequires:  perl(Test::More) >= 0.98
+
+BuildRequires:  perl(base)
+BuildRequires:  perl(bytes)
 BuildRequires:  perl(strict)
-BuildRequires:  perl(warnings)
 BuildRequires:  perl(utf8)
-BuildRequires:  perl(File::Basename)
-BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(warnings)
 
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
@@ -52,5 +57,8 @@
 %{_mandir}/man3/*
 
 %changelog
+* Sat Oct 22 2016 Ralf Corsépius <corsepiu> - 0.23-2
+- Reflect feedback from review.
+
 * Sat Oct 08 2016 Ralf Corsépius <corsepiu> - 0.23-1
 - Initial Fedora packages.


> FIX: Build-require `perl(File::Copy)' (Build.PL:54).
+BuildRequires:  perl(File::Copy)
Ok.

> FIX: Build-require `perl(base)' (builder/MyBuilder.pm:5).
+BuildRequires:  perl(base)
Ok.

> FIX: Build-require `perl(File::Path)' (builder/MyBuilder.pm:7).
Not addressed.
FIX: Please build-require it.

> FIX: Build-require `perl(bytes)' (lib/WWW/Form/UrlEncoded/PP.pm:109).
+BuildRequires:  perl(bytes)
Ok.

The perl(File::Copy) is a good catch.

$ rpmlint perl-WWW-Form-UrlEncoded.spec ../SRPMS/perl-WWW-Form-UrlEncoded-0.23-2.fc26.src.rpm ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-2.fc26.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

Package build in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16186162). Ok.

Please add a build-time dependency on the `perl(File::Path))' before building this package.
Resolution: Package APPROVED.

Comment 4 Ralf Corsepius 2016-10-24 12:32:40 UTC

(In reply to Petr Pisar from comment #3)
> Spec file changes:

> > FIX: Build-require `perl(File::Path)' (builder/MyBuilder.pm:7).
> Not addressed.
> FIX: Please build-require it.

This was addressed. 

I commented out the offending line as part of WWW-Form-UrlEncoded-0.23-arch.patch:
...
+#use File::Spec;
+#use File::Path;
+#
+#sub ACTION_code {
...


> Resolution: Package APPROVED.
Thanks.

Comment 5 Gwyn Ciesla 2016-10-24 12:56:42 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-WWW-Form-UrlEncoded

Comment 6 Petr Pisar 2016-10-24 13:37:33 UTC

Indeed. I read the the upstream code and forgot on the patch. You are right.

Comment 7 Fedora Update System 2016-10-25 01:21:52 UTC

perl-WWW-Form-UrlEncoded-0.23-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-47be4f58ae

Comment 8 Fedora Update System 2016-10-25 02:21:31 UTC

perl-WWW-Form-UrlEncoded-0.23-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9fa0374cf8

Comment 9 Fedora Update System 2016-10-25 04:21:32 UTC

perl-WWW-Form-UrlEncoded-0.23-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d69029d61c

Comment 10 Fedora Update System 2016-10-31 07:35:58 UTC

perl-WWW-Form-UrlEncoded-0.23-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2016-11-01 13:22:10 UTC

perl-WWW-Form-UrlEncoded-0.23-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2016-11-01 16:23:25 UTC

perl-WWW-Form-UrlEncoded-0.23-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.