Bug 1382928 - Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser
Summary: Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1382922 1382926
Blocks: 1382923
TreeView+ depends on / blocked
 
Reported: 2016-10-08 12:05 UTC by Ralf Corsepius
Modified: 2016-11-30 05:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-30 05:28:01 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Ralf Corsepius 2016-10-08 12:05:34 UTC
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-HTTP-Entity-Parser.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-HTTP-Entity-Parser-0.18-1.fc26.src.rpm
Description:
HTTP::Entity::Parser is a PSGI-compliant HTTP Entity parser. This module
also is compatible with HTTP::Body. Unlike HTTP::Body, HTTP::Entity::Parser
reads HTTP entities from PSGI's environment $env->{'psgi.input'} and parses
it. This module supports application/x-www-form-urlencoded, multipart/form-
data and application/json.

Fedora Account System Username: corsepiu

Comment 1 Jitka Plesnikova 2016-11-02 14:50:31 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
TODO: Remove perl(Module::Build) from build-require, it is not used
FIX: Please add following build-requires:
   - perl(base) - t/Util.pm:5
   - perl(Carp) - lib/HTTP/Entity/Parser/MultiPart.pm:7
   - perl(Exporter) - t/Util.pm:5
   - perl(Fcntl) - lib/HTTP/Entity/Parser/MultiPart.pm:8
   - perl(File::Basename) - t/01_content_type/multipart.t:8
   - perl(HTTP::Headers) - t/01_content_type/multipart.t:6
   - perl(IO::File) - t/Util.pm:6
   - perl(strict) - lib/HTTP/Entity/Parser.pm:4
   - perl(utf8) - t/01_content_type/json.t:6
   - perl(warnings) - lib/HTTP/Entity/Parser.pm:5

$ rpm -qp --requires perl-HTTP-Entity-Parser-0.18-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.8.5
      1 perl(Carp)
      1 perl(Encode)
      1 perl(Fcntl)
      1 perl(File::Temp)
      1 perl(HTTP::MultiPartParser)
      1 perl(JSON::MaybeXS)
      1 perl(Module::Load)
      1 perl(Stream::Buffered)
      1 perl(WWW::Form::UrlEncoded)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-HTTP-Entity-Parser-0.18-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(HTTP::Entity::Parser) = 0.18
      1 perl(HTTP::Entity::Parser::JSON)
      1 perl(HTTP::Entity::Parser::MultiPart)
      1 perl(HTTP::Entity::Parser::OctetStream)
      1 perl(HTTP::Entity::Parser::UrlEncoded)
      1 perl-HTTP-Entity-Parser = 0.18-1.fc26
Binary provides are Ok.

Rpmlint is ok. It reports only spelling errors.

TODO: Please packed 'eg' to %doc.

Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

The package is not approved.

Comment 3 Jitka Plesnikova 2016-11-03 11:35:29 UTC
> BuildRequires
> TODO: Remove perl(Module::Build) from build-require, it is not used
-BuildRequires:  perl(Module::Build)
Ok.

> FIX: Please add following build-requires:
>    - perl(base) - t/Util.pm:5
>    - perl(Carp) - lib/HTTP/Entity/Parser/MultiPart.pm:7
>    - perl(Exporter) - t/Util.pm:5
>    - perl(Fcntl) - lib/HTTP/Entity/Parser/MultiPart.pm:8
>    - perl(File::Basename) - t/01_content_type/multipart.t:8
>    - perl(HTTP::Headers) - t/01_content_type/multipart.t:6
>    - perl(IO::File) - t/Util.pm:6
>    - perl(strict) - lib/HTTP/Entity/Parser.pm:4
>    - perl(utf8) - t/01_content_type/json.t:6
>    - perl(warnings) - lib/HTTP/Entity/Parser.pm:5
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(Exporter)
+BuildRequires:  perl(Fcntl)
+BuildRequires:  perl(File::Basename)
+BuildRequires:  perl(HTTP::Headers)
+BuildRequires:  perl(IO::File)
+BuildRequires:  perl(base)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(utf8)
+BuildRequires:  perl(warnings)
Ok.

The package is approved.

Comment 4 Gwyn Ciesla 2016-11-03 12:59:24 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-HTTP-Entity-Parser

Comment 5 Fedora Update System 2016-11-20 06:11:08 UTC
perl-HTTP-Entity-Parser-0.18-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-030fe5a9b3

Comment 6 Fedora Update System 2016-11-21 21:11:21 UTC
perl-HTTP-Entity-Parser-0.18-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-030fe5a9b3

Comment 7 Fedora Update System 2016-11-30 05:28:01 UTC
perl-HTTP-Entity-Parser-0.18-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.