Bug 1388001

Summary:	hammer prompts to use nil in :request_timeout, doing so leads to an error
Product:	Red Hat Satellite	Reporter:	Peter Ondrejka <pondrejk>
Component:	Hammer	Assignee:	Tomas Strachota <tstrachota>
Status:	CLOSED ERRATA	QA Contact:	orabin
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.3.0	CC:	bbuckingham, dhlavacd, ehelms, inecas, jcallaha, mbacovsk, orabin, tstrachota
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-21 16:51:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Peter Ondrejka 2016-10-24 07:48:29 UTC

Description of problem:

Attempting to turn off timeouts by setting :request_timeout: -1 in .hammer/cli_config.yml leads to:

# hammer --csv host list 
To disable read timeouts, please set timeout to nil instead of -1
...

Which is ok, but setting :request_timeout: nil as requested leads to:

# hammer --csv host list 
Error: can't convert String into time interval

With :request_timeout: null 

# hammer --csv host list 
...
Works correctly

Expected results:
The user alert shown with :request_timeout: -1 should state "null" instead of "nill".

Comment 3 Bryan Kearney 2016-10-24 16:20:15 UTC

Upstream bug assigned to tstrachota

Comment 4 Bryan Kearney 2016-10-24 16:20:19 UTC

Upstream bug assigned to tstrachota

Comment 5 Bryan Kearney 2016-12-22 15:11:43 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/16775 has been resolved.

Comment 6 orabin 2017-08-30 08:47:14 UTC

Verified.
Version Tested: Satellite-6.3 Snap 13.

Steps to verify:
1. add :request_timeout: -1 in .hammer/cli.modules.d/foreman.yml
2. run hammer --csv host list


Results: the list was returned without any message about errors in request_timeout.

Comment 7 Satellite Program 2018-02-21 16:51:07 UTC

Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> 
> For information on the advisory, and where to find the updated files, follow the link below.
> 
> If the solution does not work for you, open a new bug report.
> 
> https://access.redhat.com/errata/RHSA-2018:0336