Bug 1388001 - hammer prompts to use nil in :request_timeout, doing so leads to an error
Summary: hammer prompts to use nil in :request_timeout, doing so leads to an error
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Hammer
Version: 6.3.0
Hardware: Unspecified
OS: Unspecified
medium
medium vote
Target Milestone: Unspecified
Assignee: Tomas Strachota
QA Contact: orabin
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-24 07:48 UTC by Peter Ondrejka
Modified: 2019-08-12 16:37 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-21 16:51:07 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 16775 0 Normal Closed specifying request_timeout: -1 yields incorrect deprecation warning 2020-12-11 00:01:29 UTC

Description Peter Ondrejka 2016-10-24 07:48:29 UTC 
Description of problem:

Attempting to turn off timeouts by setting :request_timeout: -1 in .hammer/cli_config.yml leads to:

# hammer --csv host list 
To disable read timeouts, please set timeout to nil instead of -1
...

Which is ok, but setting :request_timeout: nil as requested leads to:

# hammer --csv host list 
Error: can't convert String into time interval

With :request_timeout: null 

# hammer --csv host list 
...
Works correctly

Expected results:
The user alert shown with :request_timeout: -1 should state "null" instead of "nill".
Comment 3 Bryan Kearney 2016-10-24 16:20:15 UTC 
Upstream bug assigned to tstrachota
Comment 4 Bryan Kearney 2016-10-24 16:20:19 UTC 
Upstream bug assigned to tstrachota
Comment 5 Bryan Kearney 2016-12-22 15:11:43 UTC 
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/16775 has been resolved.
Comment 6 orabin 2017-08-30 08:47:14 UTC 
Verified.
Version Tested: Satellite-6.3 Snap 13.

Steps to verify:
1. add :request_timeout: -1 in .hammer/cli.modules.d/foreman.yml
2. run hammer --csv host list


Results: the list was returned without any message about errors in request_timeout.
Comment 7 Satellite Program 2018-02-21 16:51:07 UTC 
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> 
> For information on the advisory, and where to find the updated files, follow the link below.
> 
> If the solution does not work for you, open a new bug report.
> 
> https://access.redhat.com/errata/RHSA-2018:0336
Note You need to log in before you can comment on or make changes to this bug.