Bug 1389784
| Summary: | Review Request: python-scour - An SVG scrubber | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-10 15:51:58 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1389772 | ||
|
Description
Gwyn Ciesla
2016-10-28 15:27:54 UTC
The error for the GitHub Source URL is easy to fix.
You can change it to one of the following:
Source0: %{url}/archive/v%{version}/%{modname}-%{version}.tar.gz
or
Source0: %{url}/archive/v%{version}.tar.gz#/%{modname}-%{version}.tar.gz
Both are valid.
Thanks! SRPM: https://fedorapeople.org/~limb/review/python-scour/python-scour-0.35-2.fc24.src.rpm SPEC: https://fedorapeople.org/~limb/review/python-scour/python-scour.spec The licensedir conditional at the top needs the extra "%" removed on the %doc, otherwise it defines "%license" as "%%doc", which doesn't work. Also, the conditional should be near the files list rather than the top. I forget why this is the case, but I think it was important. Fixed, same URLs. fedora-review is happy about the package (minus the manpage warning, which I'm ignoring). The package name, version, and licensing looks good. It obeys our guidelines for Python packaging. PACKAGE APPROVED. Excellent, thank you so much! Please post a link to a review of yours, if you have one. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-scour python-scour-0.35-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3565264129 python-scour-0.35-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dfac269ab2 inkscape-0.92-5.pre2.fc25, python-scour-0.35-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cc91f59804 python-scour-0.35-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-scour-0.35-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. inkscape-0.92-5.pre2.fc25, python-scour-0.35-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |