Bug 1390901

Summary:	Delete option is not disabled for built-in alerts
Product:	Red Hat CloudForms Management Engine	Reporter:	Dmitry Misharov <dmisharo>
Component:	UI - OPS	Assignee:	lgalis
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dmitry Misharov <dmisharo>
Severity:	low	Docs Contact:
Priority:	medium
Version:	5.7.0	CC:	dajohnso, dclarizi, dmisharo, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone:	GA
Target Release:	cfme-future
Hardware:	All
OS:	All
Whiteboard:	alert:ui
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-31 06:11:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:

Description Dmitry Misharov 2016-11-02 08:35:06 UTC

Description of problem:
It's impossible to delete built-in alerts, but "Delete" option is not disabled. In case when you try to delete a built-in alert a flash message will be thrown "Alert can not be deleted" and the pointer will be moved to "All Alerts". If you try to add an alert edit screen will be opened of the alert, which we tried to delete.

Version-Release number of selected component (if applicable):
5.7.0.9-beta2.1.20161101182054_eb0afaa 

How reproducible:
Always

Steps to Reproduce:
1. Navigate to Control->Explorer.
2. Expand Alerts accordion.
3. Pick some built-in alert.
4. Try to delete it.
5. Try to add a new alert.

Actual results:
Edit screen is opened of the alert, which we tried to delete.

Expected results:
Alert adding screen should be opened.

Comment 2 Dave Johnson 2016-11-16 06:11:55 UTC

Dmitry, is this a regression from 5.6.2.2 (not 5.6.3) or is the option there as well?  If not, please add regression keyword in keywords field.

Comment 3 Dmitry Misharov 2016-11-16 07:56:00 UTC

"Delete" option is not disabled in 5.6.2.2 too for built-in alerts, but this issue doesn't occur for 5.5.2.2.

Comment 4 Jozef Zigmund 2017-01-30 17:06:17 UTC

Hi Dmitry, according to the https://bugzilla.redhat.com/show_bug.cgi?id=1305182 it was fixed in 5.6.0.4 to be able call 'Delete' on all Alerts, because probably we are not able to check whether an Alert was pre-defined or was custom one.

I noticed that in current master is not working "Add a new Alert", in the log I can see the error:

[----] I, [2017-01-30T18:03:26.171165 #11502:2b0d476d908c]  INFO -- : Started POST "/miq_policy/x_button?pressed=alert_new" for ::1 at 2017-01-30 18:03:26 +0100
[----] I, [2017-01-30T18:03:26.207615 #11502:2b0d476d908c]  INFO -- : Processing by MiqPolicyController#x_button as JS
[----] I, [2017-01-30T18:03:26.207789 #11502:2b0d476d908c]  INFO -- :   Parameters: {"pressed"=>"alert_new"}
[----] F, [2017-01-30T18:03:27.917371 #11502:2b0d476d908c] FATAL -- : Error caught: [ActiveRecord::SubclassNotFound] Invalid single-table inheritance type: ManageIQ::Providers::AnsibleTower::ConfigurationManager is not a subclass of ExtManagementSystem
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/inheritance.rb:189:in `find_sti_class'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/inheritance.rb:163:in `discriminate_class_for_record'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/persistence.rb:67:in `instantiate'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/querying.rb:50:in `block (2 levels) in find_by_sql'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/result.rb:52:in `block in each'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/result.rb:52:in `each'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/result.rb:52:in `each'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/querying.rb:50:in `map'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/querying.rb:50:in `block in find_by_sql'
/home/jzigmund/.gem/ruby/gems/activesupport-5.0.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/querying.rb:49:in `find_by_sql'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/relation.rb:702:in `exec_queries'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/relation.rb:583:in `load'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/relation.rb:260:in `records'
/home/jzigmund/.gem/ruby/gems/activerecord-5.0.1/lib/active_record/relation/delegation.rb:38:in `each'
/home/jzigmund/manageiq/plugins/manageiq-ui-classic/app/controllers/miq_policy_controller/alerts.rb:284:in `alert_build_edit_screen'

according to the error, DanC could you reassign the bug to any person who is working with ::AnsibleTower::ConfigurationManager?

Comment 7 Dmitry Misharov 2017-08-31 06:11:17 UTC

I can't reproduce the issue anymore in 5.8.2.0.20170824192913_b09a5f8 and 5.7.3.2.20170621144854_6c833cc, therefore I'm closing it as "currentrelease".