Bug 1391130
| Summary: | [UI] - The edit bond interface dialog window is broken once choosing the bonding mode 'Custom' | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Michael Burman <mburman> | ||||||
| Component: | BLL.Network | Assignee: | Dominik Holler <dholler> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Michael Burman <mburman> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 4.0.5.5 | CC: | awels, bugs, danken, dholler, myakove, vszocs | ||||||
| Target Milestone: | ovirt-4.1.0-alpha | Flags: | rule-engine:
ovirt-4.1+
rule-engine: planning_ack+ danken: devel_ack+ myakove: testing_ack+ |
||||||
| Target Release: | 4.1.0 | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2017-02-01 14:34:35 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1216600 [details]
screenshot 2
Vojtech, can you guess what has triggered this ugliness in 4.1, and how it should be fixed? (In reply to Dan Kenigsberg from comment #2) > Vojtech, can you guess what has triggered this ugliness in 4.1, and how it > should be fixed? Hm, according to screenshots, 4.0.5 seems to be affected too. We did a lot of changes across UI dialogs since 4.0 so it's hard to tell. Anyway, the code in question is: SetupNetworksBondPopupView.java SetupNetworksBondPopupView.ui.xml The ui.xml template uses <g:VerticalPanel> which should be replaced with <b:Container> + <b:Row> (Bootstrap grid system). The vertical space should accomodate the case when "Custom mode" row is visible (increase height of the dialog). Please see DataCenterPopupView.ui.xml for reference when fixing this bug. can be safely tested with nightly builds Will this be fixed for 4.0.6 as well? Verified on - 4.1.0-0.2.master.20161204231323.gite9669ad.el7.centos Dominik, would this be easy to backport to 4.0 branch? Yes, posted on https://gerrit.ovirt.org/#/c/67809/ |
Created attachment 1216599 [details] screenshot 1 Description of problem: [UI] - The edit bond interface dialog window is broken once choosing the bonding mode 'Custom'. The layouts in the edit bond dialog are broken in custom bond mode. Version-Release number of selected component (if applicable): 4.0.5.5-0.1.el7ev 4.1.0-0.0.master.20161101211323.git410903b.el7.centos How reproducible: 100% Steps to Reproduce: 1. Create bond in ui setup networks and choose custom bond mode Actual results: The layouts in the edit bond are broken