Bug 1391130 - [UI] - The edit bond interface dialog window is broken once choosing the bonding mode 'Custom'
Summary: [UI] - The edit bond interface dialog window is broken once choosing the bond...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.0.5.5
Hardware: x86_64
OS: Linux
medium
low
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0
Assignee: Dominik Holler
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-02 15:43 UTC by Michael Burman
Modified: 2017-02-01 14:34 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:34:35 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
danken: devel_ack+
myakove: testing_ack+

Attachments (Terms of Use)
screenshot 1 (63.86 KB, image/png)
2016-11-02 15:43 UTC, Michael Burman 		no flags Details
screenshot 2 (48.94 KB, image/png)
2016-11-02 15:43 UTC, Michael Burman 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 66181 0 master ABANDONED webadmin: Enable/disable custom bond mode inputs 2016-11-08 21:00:14 UTC
oVirt gerrit 66242 0 master MERGED webadmin: Fix custom bond mode option input 2016-11-09 12:17:57 UTC
oVirt gerrit 67809 0 ovirt-engine-4.0 MERGED webadmin: Fix custom bond mode option input 2016-12-06 12:32:20 UTC
oVirt gerrit 67857 0 ovirt-engine-4.0 MERGED webadmin: Improve custom bond mode option input 2016-12-07 09:09:21 UTC

Description Michael Burman 2016-11-02 15:43:02 UTC 
Created attachment 1216599 [details]
screenshot 1

Description of problem:
[UI] - The edit bond interface dialog window is broken once choosing the bonding mode 'Custom'. 
The layouts in the edit bond dialog are broken in custom bond mode.

Version-Release number of selected component (if applicable):
4.0.5.5-0.1.el7ev
4.1.0-0.0.master.20161101211323.git410903b.el7.centos

How reproducible:
100%

Steps to Reproduce:
1. Create bond in ui setup networks and choose custom bond mode

Actual results:
The layouts in the edit bond are broken
Comment 1 Michael Burman 2016-11-02 15:43:30 UTC 
Created attachment 1216600 [details]
screenshot 2
Comment 2 Dan Kenigsberg 2016-11-03 21:35:04 UTC 
Vojtech, can you guess what has triggered this ugliness in 4.1, and how it should be fixed?
Comment 3 Vojtech Szocs 2016-11-07 19:13:53 UTC 
(In reply to Dan Kenigsberg from comment #2)
> Vojtech, can you guess what has triggered this ugliness in 4.1, and how it
> should be fixed?

Hm, according to screenshots, 4.0.5 seems to be affected too.

We did a lot of changes across UI dialogs since 4.0 so it's hard to tell.

Anyway, the code in question is:

  SetupNetworksBondPopupView.java
  SetupNetworksBondPopupView.ui.xml

The ui.xml template uses <g:VerticalPanel> which should be replaced with <b:Container> + <b:Row> (Bootstrap grid system).

The vertical space should accomodate the case when "Custom mode" row is visible (increase height of the dialog).
Comment 4 Vojtech Szocs 2016-11-07 19:15:46 UTC 
Please see DataCenterPopupView.ui.xml for reference when fixing this bug.
Comment 5 Dan Kenigsberg 2016-12-05 06:22:27 UTC 
can be safely tested with nightly builds
Comment 6 Michael Burman 2016-12-05 06:59:01 UTC 
Will this be fixed for 4.0.6 as well?
Comment 7 Michael Burman 2016-12-05 07:09:10 UTC 
Verified on - 4.1.0-0.2.master.20161204231323.gite9669ad.el7.centos
Comment 8 Dan Kenigsberg 2016-12-05 08:11:32 UTC 
Dominik, would this be easy to backport to 4.0 branch?
Comment 9 Dominik Holler 2016-12-05 16:36:08 UTC 
Yes, posted on https://gerrit.ovirt.org/#/c/67809/
Note You need to log in before you can comment on or make changes to this bug.