| Summary: | SSUI : language : Shopping cart validation message needs to switch language when one is selected | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Satoe Imaishi <simaishi> |
| Component: | UI - OPS | Assignee: | Martin Hradil <mhradil> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Shveta <sshveta> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.6.0 | CC: | hkataria, jhardy, mpovolny, mzazrivec, obarenbo, simaishi |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream |
| Target Release: | 5.7.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | ssui | ||
| Fixed In Version: | 5.7.0.11 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1372044 | Environment: | |
| Last Closed: | 2017-01-11 19:50:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1372044 | ||
| Bug Blocks: | |||
|
Comment 2
Shveta
2016-11-09 02:14:01 UTC
New commit detected on ManageIQ/manageiq-ui-service/master: https://github.com/ManageIQ/manageiq-ui-self_service/commit/ad53ffff069c57aa4f97b86daf75196e995122c9 commit ad53ffff069c57aa4f97b86daf75196e995122c9 Author: Martin Hradil <mhradil> AuthorDate: Thu Nov 10 10:29:06 2016 +0000 Commit: Martin Hradil <mhradil> CommitDate: Thu Nov 10 10:29:06 2016 +0000 Reload after succesful login, to ensure language is switched correctly https://bugzilla.redhat.com/show_bug.cgi?id=1391742 client/app/states/login/login.state.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) New commit detected on ManageIQ/manageiq-ui-service/master: https://github.com/ManageIQ/manageiq-ui-self_service/commit/fc5f7377160156a1e427a959070e4028b906c687 commit fc5f7377160156a1e427a959070e4028b906c687 Author: Martin Hradil <mhradil> AuthorDate: Wed Nov 9 16:53:32 2016 +0000 Commit: Martin Hradil <mhradil> CommitDate: Thu Nov 10 10:28:53 2016 +0000 Reload the whole page after switching the language moving to vertical menu, we've lost the ability to translate menu items on the fly this got fixed by #299, but it only works once, because it mutates the original object, so changing from language A to language B tries to find the language A string in catalog (so only works if A=English) unfortunately we can't *not* mutate the original object and show a copy, because then it stops getting the badge count updates every minute (only the original gets updated) So.. triggering a full browser reload after switching the language, meaning the state gets recreated anew, in English, and is only ever translated once https://bugzilla.redhat.com/show_bug.cgi?id=1391742 .../app/components/language-switcher/language-switcher.directive.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Fixed, Verified in 5.7.0.11-rc1.20161115160629_46cf4f1 |