Bug 1391742 - SSUI : language : Shopping cart validation message needs to switch language when one is selected
Summary: SSUI : language : Shopping cart validation message needs to switch language w...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.7.0
Assignee: Martin Hradil
QA Contact: Shveta
URL:
Whiteboard: ssui
Depends On: 1372044
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-03 22:13 UTC by Satoe Imaishi
Modified: 2017-01-12 05:17 UTC (History)
6 users (show)

Fixed In Version: 5.7.0.11
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1372044
Environment:
Last Closed: 2017-01-11 19:50:22 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:


Attachments (Terms of Use)

Comment 2 Shveta 2016-11-09 02:14:01 UTC

Not fixed in 5.7.0.9-beta2.1.20161101182054_eb0afaa.
Will check in next build

Comment 4 CFME Bot 2016-11-10 14:34:10 UTC
New commit detected on ManageIQ/manageiq-ui-service/master:
https://github.com/ManageIQ/manageiq-ui-self_service/commit/ad53ffff069c57aa4f97b86daf75196e995122c9

commit ad53ffff069c57aa4f97b86daf75196e995122c9
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Nov 10 10:29:06 2016 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Thu Nov 10 10:29:06 2016 +0000

    Reload after succesful login, to ensure language is switched correctly
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1391742

 client/app/states/login/login.state.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comment 5 CFME Bot 2016-11-10 14:34:15 UTC
New commit detected on ManageIQ/manageiq-ui-service/master:
https://github.com/ManageIQ/manageiq-ui-self_service/commit/fc5f7377160156a1e427a959070e4028b906c687

commit fc5f7377160156a1e427a959070e4028b906c687
Author:     Martin Hradil <mhradil>
AuthorDate: Wed Nov 9 16:53:32 2016 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Thu Nov 10 10:28:53 2016 +0000

    Reload the whole page after switching the language
    
    moving to vertical menu, we've lost the ability to translate menu items on the fly
    
    this got fixed by #299, but it only works once, because it mutates the original object, so changing from language A to language B tries to find the language A string in catalog (so only works if A=English)
    
    unfortunately we can't *not* mutate the original object and show a copy, because then it stops getting the badge count updates every minute (only the original gets updated)
    
    So.. triggering a full browser reload after switching the language, meaning the state gets recreated anew, in English, and is only ever translated once
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1391742

 .../app/components/language-switcher/language-switcher.directive.js   | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 6 Shveta 2016-11-16 10:06:41 UTC
Fixed,
Verified in 5.7.0.11-rc1.20161115160629_46cf4f1


Note You need to log in before you can comment on or make changes to this bug.