Bug 1394148
Summary: | Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Wim Taymans <wtaymans> | |
Component: | Package Review | Assignee: | Matthew Miller <mattdm> | |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | medium | Docs Contact: | ||
Priority: | medium | |||
Version: | rawhide | CC: | mattdm, package-review, wtaymans, yselkowi | |
Target Milestone: | --- | Flags: | mattdm:
fedora-review+
|
|
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | If docs needed, set a value | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | gstreamer1-plugins-ugly-free (view as bug list) | Environment: | ||
Last Closed: | 2016-11-22 05:09:45 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1394147 | |||
Bug Blocks: |
Description
Wim Taymans
2016-11-11 08:07:59 UTC
Not a blocker but should be fixed: BuildRequires: libmpg123-devel but in bug #1394147, the package actually creates mpg123-libs-devel. That subpackage provides libmpg123-devel, so it works, but that's kind of ugly I think. This doesn't built for me -- fails with RPM build errors: File not found: /home/mattdm/rpmbuild/BUILDROOT/gstreamer1-plugin-mpg123-1.10.0-1.fc25.mattdm.x86_64/usr/lib64/gstreamer-1.0/libgstmpg123.so ... which file seems to actually have landed at /home/mattdm/rpmbuild/BUILDROOT/gstreamer1-plugin-mpg123-1.10.0-1.fc25.mattdm.x86_64/usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstmpg123.so -- that is, it's in /usr/lib/x86_64-linux-gnu/gstreamer-1.0/ rather than /usr/lib64/gstreamer-1.0/ as expected. (Building as me in F25.) I'm not an expert in how gstreamer1 plugins work, but looks like maybe the "ninja-build" thing doesn't know about Fedora filesystem conventions. Updated files: https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-mpg123.spec https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-mpg123-1.10.0-2.fc24.src.rpm It installs in the right place for me. I have: meson.noarch 0.35.0-3.fc24 @updates ninja-build.x86_64 1.7.1-3.fc24 @updates Still not working for me. I get + ninja-build -v install [0/1] '/usr/bin/python3' '/usr/bin/meson' '--internal' 'install' '/home/mattdm/rpmbuild/BUILD/gst-plugin-mpg123-1.10.0/rpmbuilddir/meson-private/install.dat' Installing ext/mpg123/libgstmpg123.so to /home/mattdm/rpmbuild/BUILDROOT/gstreamer1-plugin-mpg123-1.10.0-2.fc25.mattdm.x86_64/usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstmpg123.so I have meson-0.35.1-1.fc25.noarch ninja-build-1.7.1-3.fc25.x86_64 Okay, builds fine in mock. Must be something weird in my local environment. Everything else looks good. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gstreamer1-plugin-mpg123 Are there any other parts of gst-plugins-ugly which we can include as a (slightly) more complete gstreamer1-plugins-ugly-free? There are five plugins under gst/ with actual code: * asfdemux: demuxer for Microsoft's Advanced Streaming Format * dvdlpcmdec: Decode DVD LPCM frames into standard PCM * dvdsub: DVD subtitle parser and decoder * realmedia: RealMedia support * xingmux: add Xing tags to MP3 files And the following plugins under ext/ which just wrap other libraries which are, or could be, in Fedora: * cdio: read CD audio with libcdio (which is free but GPL) * dvdread: access DVDs with libdvdread (which is free but GPL; note that there is another plugin already in gstreamer1-plugins-bad-free which uses libdvd{nav,read}) * mad: MP3 decoding with libmad (not yet in Fedora, but should be acceptable as a MP3 decoder; license is GPL) There are others, but their dependent libraries are not in Fedora for legal reasons, or just obsolete (namely, libsidplay). Precedence is that ext/ plugins need not be removed from the tarballs even if they wrap unacceptable libraries, since they are just wrappers. gstreamer1-plugin-mpg123 is in. Opened a separate bug for a possible -ugly-free. |