Spec URL: https://people.freedesktop.org/~wtay/SPECS/mpg123.spec SRPM URL: https://people.freedesktop.org/~wtay/SRPMS/mpg123-1.23.8-1.fc24.src.rpm Description: Real time MPEG 1.0/2.0/2.5 audio player/decoder for layers 1, 2 and 3 (most commonly MPEG 1.0 layer 3 aka MP3), as well as re-usable decoding and output libraries. Fedora Account System Username: wtaymans This is the package taken from rpmfusion and updated to the latest upstream version.
Not a blocker, but I'm curious about the plugin Recommends:. I have a default Fedora Workstation setup which of course uses pulseaudio. I installed the base rpm and libs but not the plugin, and the command-line tool plays back just fine — what does the plugin gain me?
nit: typo in plugins-p(l)ulseaudio subpackage.
@Wim: Unless the situation has changed recently, you cannot use rich dependencies in Requires, Recommends, or Conflicts until Fedora release engineering tools are updated to handle this without breaking. CC'ing Dennis Gilmore, who can confirm whether this is still true.
If it is in fact still the case, you can just flip the relationship to "Supplements" with rich deps in each of the plugin packages. That will work the same way and tools like Koji, Bodhi, pungi, and mash won't choke.
Also not a blocker, but there are obsolete m4 macros used in autotools. See https://fedorahosted.org/FedoraReview/wiki/AutoTools
Thanks Neal — good catch. Wim, can you fix that? https://fedoraproject.org/wiki/Packaging:Guidelines#Rich.2FBoolean_dependencies Otherwise, this looks good to me -- I ran fedora-review and the only issues it shows are due to it being somewhat confused about the devel package being mpg123-libs-devel instead of mpg123-devel. I don't *think* this is an actual problem.
Updated files: https://people.freedesktop.org/~wtay/SPECS/mpg123.spec https://people.freedesktop.org/~wtay/SRPMS/mpg123-1.23.8-2.fc24.src.rpm
Neal (or someone) can you comment on the Enhances/Supplements in the updated package?
The Enhances is pointless, so remove them. You already have a hard Requires on it anyway. The Supplements look good to me. Please don't name devel subpackages "libs-devel". That's just asking for trouble because it's inconsistent with how we generally name development subpackages. Please change it to "mpg123-devel".
Neal, do you think the devel package name is a hard blocker? I agree it would e more consistent. I guess we can do taht with another provides/obsoletes on the existing (slightly odd) name as there is for libmpg123-devel. Wim, can you fix the "Plulseaudio" typo while we're at it?
Updated files: https://people.freedesktop.org/~wtay/SPECS/mpg123.spec https://people.freedesktop.org/~wtay/SRPMS/mpg123-1.23.8-3.fc24.src.rpm Also: https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-mpg123.spec https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-mpg123-1.10.0-3.fc24.src.rpm because -libs-devel -> -devel
Updated files with Obsoletes: -lib-devel
Looks great to me. Review accepted.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mpg123
mpg123-1.23.8-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-dec08a99bd
(In reply to Neal Gompa from comment #3) > @Wim: > > Unless the situation has changed recently, you cannot use rich dependencies > in Requires, Recommends, or Conflicts until Fedora release engineering tools > are updated to handle this without breaking. In Recommends you can use it fine.
(In reply to Igor Gnatenko from comment #16) > (In reply to Neal Gompa from comment #3) > > @Wim: > > > > Unless the situation has changed recently, you cannot use rich dependencies > > in Requires, Recommends, or Conflicts until Fedora release engineering tools > > are updated to handle this without breaking. > In Recommends you can use it fine. No, you cannot use them in Recommends because Yum was adapted to read them, so now that it doesn't ignore them, everything breaks when you put rich dependencies in them.
Do you have any plans to build this for other branches? I would be interested in an EPEL7 build, and am willing to help comaintain it if you're interested.
mpg123-1.23.8-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dec08a99bd
*** Bug 625481 has been marked as a duplicate of this bug. ***
This has already been approved by Fedora Legal.
I don't get why Supplements is relevant here ? You will get mpg123-plugins-pulseaudio as soon as you get pulseaudio. Even if you don't have mpg123. Same for portaudio. thx for moving the package here.
mpg123-1.23.8-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.