Bug 1394951
| Summary: | timelines is broken in IE11 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Ievgen Zapolskyi <izapolsk> | ||||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ievgen Zapolskyi <izapolsk> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 5.7.0 | CC: | cpelland, hkataria, jhardy, mpovolny, obarenbo, sdoyle, simaishi | ||||||
| Target Milestone: | GA | Keywords: | TestOnly | ||||||
| Target Release: | 5.8.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | ui:timeline:browser | ||||||||
| Fixed In Version: | 5.8.0.0 | Doc Type: | Release Note | ||||||
| Doc Text: |
Timelines were not working with IE 11 due to IE adding an event with null data causing JavaScript errors. The fix involved removing leftover code around code to build timelines differently for IE. Timelines will now display properly.
|
Story Points: | --- | ||||||
| Clone Of: | |||||||||
| : | 1399210 (view as bug list) | Environment: | |||||||
| Last Closed: | 2017-06-12 16:58:58 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1399210 | ||||||||
| Attachments: |
|
||||||||
Dana, please take a look and see if you think this is related to our code. Thanks! Harpreet - I can't get timelines to run in IE at all - I'm attaching the image to show what's broken. We have a fix in patternfly coming that is breaking ManageIQ so that will need to be applied as well. Created attachment 1221315 [details]
IE11 error screenshot
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/74340dd394a29089953233f471042d19997b2011 commit 74340dd394a29089953233f471042d19997b2011 Author: Harpreet Kataria <hkataria> AuthorDate: Tue Nov 22 13:44:42 2016 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Nov 22 13:44:42 2016 -0500 Removed leftover code around code to build timelines differently for IE. Fixed JS code to only add events with data, for some reason IE was adding an event with null data causing JS errors. https://bugzilla.redhat.com/show_bug.cgi?id=1394951 app/assets/javascripts/miq_timeline.js | 4 ++-- app/controllers/application_controller/timelines.rb | 8 +------- app/controllers/dashboard_controller.rb | 9 +-------- app/controllers/miq_capacity_controller.rb | 8 +------- 4 files changed, 5 insertions(+), 24 deletions(-) |
Created attachment 1220533 [details] timelines screenshot Description of problem: see screenshot Version-Release number of selected component (if applicable): 5.7.0.10 How reproducible: 100% Steps to Reproduce: 1. Open Timelines page for any provider and try to generate timelines view for one/all Management events categories Actual results: timelines view gets corrupted Expected results: correct rendering of timelines view Additional info: