Bug 1394951 - timelines is broken in IE11
Summary: timelines is broken in IE11
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.7.0
Hardware: Unspecified
OS: Linux
high
high
Target Milestone: GA
: 5.8.0
Assignee: Harpreet Kataria
QA Contact: Ievgen Zapolskyi
URL:
Whiteboard: ui:timeline:browser
Depends On:
Blocks: 1399210
TreeView+ depends on / blocked
 
Reported: 2016-11-14 20:55 UTC by Ievgen Zapolskyi
Modified: 2017-06-12 16:58 UTC (History)
7 users (show)

Fixed In Version: 5.8.0.0
Doc Type: Release Note
Doc Text:
Timelines were not working with IE 11 due to IE adding an event with null data causing JavaScript errors. The fix involved removing leftover code around code to build timelines differently for IE. Timelines will now display properly.
Clone Of:
: 1399210 (view as bug list)
Environment:
Last Closed: 2017-06-12 16:58:58 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
timelines screenshot (86.60 KB, image/png)
2016-11-14 20:55 UTC, Ievgen Zapolskyi
no flags Details
IE11 error screenshot (121.62 KB, image/jpeg)
2016-11-16 18:29 UTC, dgutride
no flags Details

Description Ievgen Zapolskyi 2016-11-14 20:55:01 UTC
Created attachment 1220533 [details]
timelines screenshot

Description of problem:
see screenshot

Version-Release number of selected component (if applicable):
5.7.0.10

How reproducible:
100%

Steps to Reproduce:
1. Open Timelines page for any provider and try to generate timelines view for one/all Management events categories

Actual results:
timelines view gets corrupted

Expected results:
correct rendering of timelines view

Additional info:

Comment 3 Serena 2016-11-14 21:36:33 UTC
Dana, please take a look and see if you think this is related to our code. Thanks!

Comment 4 dgutride 2016-11-16 18:28:33 UTC
Harpreet - I can't get timelines to run in IE at all - I'm attaching the image to show what's broken.  We have a fix in patternfly coming that is breaking ManageIQ so that will need to be applied as well.

Comment 5 dgutride 2016-11-16 18:29:35 UTC
Created attachment 1221315 [details]
IE11 error screenshot

Comment 6 Harpreet Kataria 2016-11-22 18:47:33 UTC
https://github.com/ManageIQ/manageiq/pull/12798

Comment 7 CFME Bot 2016-11-22 21:01:50 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/74340dd394a29089953233f471042d19997b2011

commit 74340dd394a29089953233f471042d19997b2011
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Nov 22 13:44:42 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Nov 22 13:44:42 2016 -0500

    Removed leftover code around code to build timelines differently for IE.
    
    Fixed JS code to only add events with data, for some reason IE was adding an event with null data causing JS errors.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1394951

 app/assets/javascripts/miq_timeline.js              | 4 ++--
 app/controllers/application_controller/timelines.rb | 8 +-------
 app/controllers/dashboard_controller.rb             | 9 +--------
 app/controllers/miq_capacity_controller.rb          | 8 +-------
 4 files changed, 5 insertions(+), 24 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.