Bug 1396068
Summary: | VM snapshot: revert option is enabled, for Active VM | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Ilanit Stein <istein> | ||||||
Component: | Providers | Assignee: | Boriso <bodnopoz> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Ilanit Stein <istein> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | 5.7.0 | CC: | agrare, akarol, cpelland, dajohnso, dclarizi, gblomqui, istein, jfrey, jhardy, kmorey, nstephan, obarenbo, simaishi | ||||||
Target Milestone: | GA | Keywords: | TestOnly | ||||||
Target Release: | 5.9.0 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | rhev | ||||||||
Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | |||||||||
: | 1402992 1447778 (view as bug list) | Environment: | |||||||
Last Closed: | 2018-03-06 14:36:44 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | RHEVM | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 1402992, 1447778 | ||||||||
Attachments: |
|
Description
Ilanit Stein
2016-11-17 12:00:10 UTC
Created attachment 1222191 [details]
VMWare screenshot VM snapshot revert
Created attachment 1222192 [details]
RHV VM screenshot snapshot revert for Active VM.
As seen in the attached screenshots, On VM snapshot dialog, - For VMWare, "Active VM" do not exist. - For RHV, "Active VM" exist, and when marked, "revert" is enabled, though should be disabled. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/75e22a87d4b00175fe49da3fc19edccdc404fa76 commit 75e22a87d4b00175fe49da3fc19edccdc404fa76 Author: borod108 <bodnopoz> AuthorDate: Mon Nov 21 15:59:34 2016 +0200 Commit: borod108 <bodnopoz> CommitDate: Mon Nov 21 16:03:50 2016 +0200 No revert for "active" snapshot In the snapshot screen when the "active" snapshot is selected the revert button should be disabled. https://bugzilla.redhat.com/show_bug.cgi?id=1396068 app/helpers/application_helper/toolbar_builder.rb | 1 + 1 file changed, 1 insertion(+) I fully support that Dan, I have asked Aziza to check this on vmware for 5.7.1. Depending on the result, if its like how you say it is, this is going to need to be re-visited. New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/ae401038f0e827632872590ddab037976c054864 commit ae401038f0e827632872590ddab037976c054864 Author: Adam Grare <agrare> AuthorDate: Thu Feb 16 11:36:24 2017 -0500 Commit: Adam Grare <agrare> CommitDate: Thu Feb 16 14:32:11 2017 -0500 Revert fix for BZ 1396068 as it breaks VMware The change to not allow revert for an active snapshot breaks VMware snapshot handling when you have a single snapshot. https://bugzilla.redhat.com/show_bug.cgi?id=1396068 .../application_helper/button/vm_snapshot_revert.rb | 4 +--- .../buttons/vm_snapshot_revert_spec.rb | 17 ++++++----------- 2 files changed, 7 insertions(+), 14 deletions(-) Moving back to ON_DEV pending a re-implementation of this functionality Aziza, per comment 10, can you weigh in on this... Looks like Adam agrees it needs to be re-implemented but curious on what say you? The reimplementation was done in https://github.com/ManageIQ/manageiq-providers-ovirt/pull/5 so I assume this should be moved to POST. Dave, Please see https://bugzilla.redhat.com/show_bug.cgi?id=1402992#c5. I had my views added in this comment. Thanks, Aziza Verified on CFME-5.9.0.4/RHV-4.1.6 |