Description of problem: On CFME, RHV provider, When VM snapshot, Active VM is marked, the revert button is enabled, and it is possible to run it. This revert fail on: "Requested VM snapshot not found, unable to RevertTo snapshot" On RHV side, when Active VM is marked, Preview option is disabled. Version-Release number of selected component (if applicable): CFME-5.7.0.11 RHV-4.0.5 How reproducible: 100% Expected results: revert option should be disabled when Active VM is marked. Additional info: Error in evm.log - [----] E, [2016-11-17T04:23:35.814966 #15065:709130] ERROR -- : MIQ(MiqQueue#deliver) Message id: [13408], Error: [Requested VM snapshot not found, unable to RevertTo snapshot] [----] E, [2016-11-17T04:23:35.815150 #15065:709130] ERROR -- : [RuntimeError]: Requested VM snapshot not found, unable to RevertTo snapshot Method:[rescue in deliver] [----] E, [2016-11-17T04:23:35.815296 #15065:709130] ERROR -- : /var/www/miq/vmdb/app/models/manageiq/providers/redhat/infra_manager/vm/operations/snapshot.rb:32:in `raw_revert_to_snapshot' /var/www/miq/vmdb/app/models/vm_or_template/operations/snapshot.rb:136:in `revert_to_snapshot' /var/www/miq/vmdb/app/models/miq_queue.rb:347:in `block in deliver' /opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:91:in `block in timeout' /opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:33:in `block in catch' /opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:33:in `catch' /opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:33:in `catch' /opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:106:in `timeout' /var/www/miq/vmdb/app/models/miq_queue.rb:343:in `deliver' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:106:in `deliver_queue_message' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:134:in `deliver_message' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:152:in `block in do_work' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:146:in `loop' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:146:in `do_work' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:334:in `block in do_work_loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:331:in `loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:331:in `do_work_loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:153:in `run' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:128:in `start' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:21:in `start_worker' /var/www/miq/vmdb/app/models/miq_worker.rb:343:in `block in start' /opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork' /opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork' /var/www/miq/vmdb/app/models/miq_worker.rb:341:in `start' /var/www/miq/vmdb/app/models/miq_worker.rb:270:in `start_worker' /var/www/miq/vmdb/app/models/miq_worker.rb:150:in `block in sync_workers' /var/www/miq/vmdb/app/models/miq_worker.rb:150:in `times' /var/www/miq/vmdb/app/models/miq_worker.rb:150:in `sync_workers' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:52:in `block in sync_workers' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `each' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `sync_workers' /var/www/miq/vmdb/app/models/miq_server.rb:158:in `start' /var/www/miq/vmdb/app/models/miq_server.rb:248:in `start' /var/www/miq/vmdb/lib/workers/evm_server.rb:65:in `start' /var/www/miq/vmdb/lib/workers/evm_server.rb:92:in `start' /var/www/miq/vmdb/lib/workers/bin/evm_server.rb:4:in `<main>' [----] I, [2016-11-17T04:23:35.815392 #15065:709130] INFO -- : MIQ(MiqQueue#delivered) Message id: [13408], State: [error], Delivered in [0.00463228] seconds [----] I, [2016-11-17T04:23:35.816441 #15065:709130] INFO -- : MIQ(MiqQueue#m_callback) Message id: [13408], Invoking Callback with args: ["Finished", "error", "Requested VM snapshot not found, unable to RevertTo snapshot", "nil"] [----] I, [2016-11-17T04:23:35.816662 #15065:709130] INFO -- : MIQ(MiqTask#update_status) Task: [55] [Finished] [Error] [Requested VM snapshot not found, unable to RevertTo snapshot]
Created attachment 1222191 [details] VMWare screenshot VM snapshot revert
Created attachment 1222192 [details] RHV VM screenshot snapshot revert for Active VM.
As seen in the attached screenshots, On VM snapshot dialog, - For VMWare, "Active VM" do not exist. - For RHV, "Active VM" exist, and when marked, "revert" is enabled, though should be disabled.
https://github.com/ManageIQ/manageiq/pull/12768
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/75e22a87d4b00175fe49da3fc19edccdc404fa76 commit 75e22a87d4b00175fe49da3fc19edccdc404fa76 Author: borod108 <bodnopoz> AuthorDate: Mon Nov 21 15:59:34 2016 +0200 Commit: borod108 <bodnopoz> CommitDate: Mon Nov 21 16:03:50 2016 +0200 No revert for "active" snapshot In the snapshot screen when the "active" snapshot is selected the revert button should be disabled. https://bugzilla.redhat.com/show_bug.cgi?id=1396068 app/helpers/application_helper/toolbar_builder.rb | 1 + 1 file changed, 1 insertion(+)
I fully support that Dan, I have asked Aziza to check this on vmware for 5.7.1. Depending on the result, if its like how you say it is, this is going to need to be re-visited.
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/ae401038f0e827632872590ddab037976c054864 commit ae401038f0e827632872590ddab037976c054864 Author: Adam Grare <agrare> AuthorDate: Thu Feb 16 11:36:24 2017 -0500 Commit: Adam Grare <agrare> CommitDate: Thu Feb 16 14:32:11 2017 -0500 Revert fix for BZ 1396068 as it breaks VMware The change to not allow revert for an active snapshot breaks VMware snapshot handling when you have a single snapshot. https://bugzilla.redhat.com/show_bug.cgi?id=1396068 .../application_helper/button/vm_snapshot_revert.rb | 4 +--- .../buttons/vm_snapshot_revert_spec.rb | 17 ++++++----------- 2 files changed, 7 insertions(+), 14 deletions(-)
Moving back to ON_DEV pending a re-implementation of this functionality
Aziza, per comment 10, can you weigh in on this... Looks like Adam agrees it needs to be re-implemented but curious on what say you?
The reimplementation was done in https://github.com/ManageIQ/manageiq-providers-ovirt/pull/5 so I assume this should be moved to POST.
Dave, Please see https://bugzilla.redhat.com/show_bug.cgi?id=1402992#c5. I had my views added in this comment. Thanks, Aziza
Verified on CFME-5.9.0.4/RHV-4.1.6