Bug 1400542 (colm)
| Summary: | Review Request: colm - Programming language designed for the analysis and transformation of computer languages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-11 00:29:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1382861 | ||
|
Description
Igor Gnatenko
2016-12-01 13:13:31 UTC
What going on with the .so file? $ objdump -p /usr/lib64/libcolm*|grep SONA SONAME libcolm-0.13.0.4.so The name is nonstandard (number before ".so"), but we have a bunch of files like that. But the SONAME is very specific, so all dependent packages will have to be rebuilt if it changes. rpmlint: colm.src: E: summary-too-long C Programming language designed for the analysis and transformation of computer languages → "Programming language for the analysis of computer languages" rpmlint also complains about incorrect-fsf-address. (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > What going on with the .so file? > $ objdump -p /usr/lib64/libcolm*|grep SONA > SONAME libcolm-0.13.0.4.so > > The name is nonstandard (number before ".so"), but we have a bunch of files > like that. But the SONAME is very specific, so all dependent packages will > have to be rebuilt if it changes. Upstream doesn't guarantee backwards compatibility. > > rpmlint: > colm.src: E: summary-too-long C Programming language designed for the > analysis and transformation of computer languages > → "Programming language for the analysis of computer languages" Easy to fix. > > rpmlint also complains about incorrect-fsf-address. Will report to upstream. Any other issues? In the real world, only ragel depends on this package ;) > Upstream doesn't guarantee backwards compatibility. OK. That's wrong, but OK. > Any other issues? %post -p /sbin/ldconfig %postun -p /sbin/ldconfig is missing. + package name is OK + latest version + provides/requires/brs look correct + builds and installs OK + rpmlint output can be ignored (see comment #c1) + fedora-review is happy + license is acceptable (GPLv2) + license is specified correctly Package is APPROVED. Please fix summary and the scriptlets. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/colm colm-0.13.0.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d26bf451c0 colm-0.13.0.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2e1979e23d colm-0.13.0.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d26bf451c0 colm-0.13.0.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2e1979e23d colm-0.13.0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. colm-0.13.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |