Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/colm.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/colm-0.13.0.4-1.fc26.src.rpm Description: Colm is a programming language designed for the analysis and transformation of computer languages. Colm is influenced primarily by TXL. It is in the family of program transformation languages. Fedora Account System Username: ignatenkobrain
What going on with the .so file? $ objdump -p /usr/lib64/libcolm*|grep SONA SONAME libcolm-0.13.0.4.so The name is nonstandard (number before ".so"), but we have a bunch of files like that. But the SONAME is very specific, so all dependent packages will have to be rebuilt if it changes. rpmlint: colm.src: E: summary-too-long C Programming language designed for the analysis and transformation of computer languages → "Programming language for the analysis of computer languages" rpmlint also complains about incorrect-fsf-address.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > What going on with the .so file? > $ objdump -p /usr/lib64/libcolm*|grep SONA > SONAME libcolm-0.13.0.4.so > > The name is nonstandard (number before ".so"), but we have a bunch of files > like that. But the SONAME is very specific, so all dependent packages will > have to be rebuilt if it changes. Upstream doesn't guarantee backwards compatibility. > > rpmlint: > colm.src: E: summary-too-long C Programming language designed for the > analysis and transformation of computer languages > → "Programming language for the analysis of computer languages" Easy to fix. > > rpmlint also complains about incorrect-fsf-address. Will report to upstream. Any other issues?
In the real world, only ragel depends on this package ;)
> Upstream doesn't guarantee backwards compatibility. OK. That's wrong, but OK. > Any other issues? %post -p /sbin/ldconfig %postun -p /sbin/ldconfig is missing. + package name is OK + latest version + provides/requires/brs look correct + builds and installs OK + rpmlint output can be ignored (see comment #c1) + fedora-review is happy + license is acceptable (GPLv2) + license is specified correctly Package is APPROVED. Please fix summary and the scriptlets.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/colm
colm-0.13.0.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d26bf451c0
colm-0.13.0.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2e1979e23d
colm-0.13.0.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d26bf451c0
colm-0.13.0.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2e1979e23d
colm-0.13.0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
colm-0.13.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.