Bug 1403235

Summary:	Review Request: perl-Net-LDAP-SID - Net::LDAP::SID Perl module
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-12-21 04:29:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1312303

Description Ralf Corsepius 2016-12-09 13:23:59 UTC

Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-SID.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-SID-0.001-1.fc26.src.rpm
Description: Active Directory Security Identifier manipulation
Fedora Account System Username: corsepiu

Comment 1 Jitka Plesnikova 2016-12-09 14:10:37 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Net-LDAP-SID-0.001-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Net-LDAP-SID-0.001-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Net::LDAP::SID) = 0.001
      1 perl-Net-LDAP-SID = 0.001-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Net-LDAP-SID*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-12-09 14:29:12 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-LDAP-SID

Comment 3 Ralf Corsepius 2016-12-09 14:31:34 UTC

Thanks for the quick review. Provided my experiences with Fedora packaging in recent months, I feared this additional dep would delay perl-Net-LDAP-Server for yet another couple of months :(

Comment 4 Jitka Plesnikova 2016-12-09 14:53:47 UTC

I can do the review of perl-Net-LDAP-Server next week, in case the perl-Net-LDAP-SID will be in rawhide.