Bug 1404473

Summary: No flash message after addition of a new policy is cancelled
Product: Red Hat CloudForms Management Engine Reporter: Nandini Chandra <nachandr>
Component: UI - OPSAssignee: Jozef Zigmund <jzigmund>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.7.0CC: dmisharo, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:control
Fixed In Version: 5.8.0.6 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1431154 (view as bug list) Environment:
Last Closed: 2017-06-12 17:29:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1431154    

Description Nandini Chandra 2016-12-13 22:48:56 UTC
Description of problem:
-----------------------


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
5.7.0.14


How reproducible:
----------------
Always


Steps to Reproduce:
-------------------
1.Navigate to the Control->Explorer page.
2.From the Policies accordion, try adding a new Control or Compliance policy for any entity except Container Image.
3.Hit Cancel button


Actual results:
---------------
No flash message is displayed.


Expected results:
-----------------
A flash message similar to this should be displayed.
Add of new Policy was cancelled by the user


Additional info:
----------------

Comment 2 Dmitry Misharov 2016-12-15 15:15:01 UTC
A flash message shown only if the branch contents some policies, otherwise it is not shown.

Comment 3 Jozef Zigmund 2017-02-27 14:28:08 UTC
Hi, I cannot reproduce it. Now it shows proper flash message, please verify.

According to the code hostory, the bugfix was provided by: https://github.com/ManageIQ/manageiq/pull/6732

Comment 4 Dmitry Misharov 2017-03-03 14:19:10 UTC
Tested in 5.8.0.3.20170301174324_1e2e0c4, there is no the flash message after canceling policy creation.

Comment 5 Dmitry Misharov 2017-03-03 14:23:01 UTC
Additional information: the issue can be reproduced when a policy folder doesn't contain any policy. That's why Container Image policies has the flash message.

Comment 7 CFME Bot 2017-03-09 11:08:01 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/dbb7381416d912da0f3488ed3e976ee9a76a59ed

commit dbb7381416d912da0f3488ed3e976ee9a76a59ed
Author:     Jozef Zigmund <jzigmund>
AuthorDate: Wed Mar 8 17:54:34 2017 +0100
Commit:     Jozef Zigmund <jzigmund>
CommitDate: Wed Mar 8 17:57:04 2017 +0100

    Added rendering flash messages partial in _policy_list when it's empty
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1404473

 app/views/miq_policy/_policy_list.html.haml | 1 +
 1 file changed, 1 insertion(+)

Comment 8 Jozef Zigmund 2017-03-09 14:29:57 UTC
Thanks to Dmitry for additional info. Fix has been merged to the master branch. Moving status to the POST

Comment 10 Dmitry Misharov 2017-03-20 07:29:47 UTC
Verified in 5.8.0.6-nightly.20170316163139_6cb8ae3. Flash messages appear after canceling policy creation.