Bug 1404575
| Summary: | TRUE and FALSE vs true and false | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Michael Peters <alice> | ||||
| Component: | freerdp | Assignee: | Ondrej Holy <oholy> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 7.3 | CC: | thudziec, tpelka | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | freerdp-1.0.2-11.el7 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-04-10 11:38:34 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1479818 | ||||||
| Attachments: |
|
||||||
FreeRDP master uses TRUE/FALSE and defines them in include/freerdp/types.h, so I probably forgot renaming them when backporting and it was built thanks to some definitions from OpenSSL header files probably. It would be nice to fix it, however, I suppose that we don't support LibreSSL, so it is not such a big problem currently... Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0724 |
Created attachment 1231453 [details] The fix for patch 9. Causes 10 and 11 to need fixes too. Description of problem: When attempting to rebuild source against LibreSSL, build fails with undeclared TRUE. Version-Release number of selected component (if applicable): 1.0.2-10 How reproducible: Always Steps to Reproduce: 1. Install LibreSSL 2. change BuildRequires: openssl-devel to BuildRequires: pkgconfig(openssl) 3. Build in a mock environment where libressl-devel is used Actual results: TRUE and FALSE from Patch9: 1-Add-support-for-Wildcard-Certificates-2-For-Gatewa.patch result in compiler error, undeclared TRUE, first use, blah Expected results: Should compile Additional info: In patch9 if you change the TRUE to true and the FALSE to false then it works. Patch10 and Patch11 are impacted by those case changes. I don't know why it builds with OpenSSL (well I haven't tried but obviously it does) but it doesn't build with LibreSSL unless changing case. I'm not a C person but I do know TRUE and FALSE need to be declared. An additional patch is also needed to build against LibreSSL but that's beyond the scope of RHEL. This I think is within scope because I think its a coding bug. I'm a little drunk right now so I apologize if I don't make senase.