Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1404575

Summary: TRUE and FALSE vs true and false
Product: Red Hat Enterprise Linux 7 Reporter: Michael Peters <alice>
Component: freerdpAssignee: Ondrej Holy <oholy>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.3CC: thudziec, tpelka
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: freerdp-1.0.2-11.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 11:38:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1479818    
Attachments:
Description Flags
The fix for patch 9. Causes 10 and 11 to need fixes too. none

Description Michael Peters 2016-12-14 07:18:06 UTC
Created attachment 1231453 [details]
The fix for patch 9. Causes 10 and 11 to need fixes too.

Description of problem:
When attempting to rebuild source against LibreSSL, build fails with undeclared TRUE.


Version-Release number of selected component (if applicable):
1.0.2-10

How reproducible:
Always

Steps to Reproduce:
1. Install LibreSSL
2. change BuildRequires: openssl-devel to BuildRequires: pkgconfig(openssl)
3. Build in a mock environment where libressl-devel is used

Actual results:
TRUE and FALSE from Patch9: 1-Add-support-for-Wildcard-Certificates-2-For-Gatewa.patch result in compiler error, undeclared TRUE, first use, blah

Expected results:
Should compile

Additional info:
In patch9 if you change the TRUE to true and the FALSE to false then it works.

Patch10 and Patch11 are impacted by those case changes.

I don't know why it builds with OpenSSL (well I haven't tried but obviously it does) but it doesn't build with LibreSSL unless changing case. I'm not a C person but I do know TRUE and FALSE need to be declared.

An additional patch is also needed to build against LibreSSL but that's beyond the scope of RHEL. This I think is within scope because I think its a coding bug.

I'm a little drunk right now so I apologize if I don't make senase.

Comment 2 Ondrej Holy 2016-12-15 08:30:38 UTC
FreeRDP master uses TRUE/FALSE and defines them in include/freerdp/types.h, so I probably forgot renaming them when backporting and it was built thanks to some definitions from OpenSSL header files probably. It would be nice to fix it, however, I suppose that we don't support LibreSSL, so it is not such a big problem currently...

Comment 8 errata-xmlrpc 2018-04-10 11:38:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0724