Bug 1404618
| Summary: | mpdris2: Switch to Python 3 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iryna Shcherbina <ishcherb> | ||||
| Component: | mpdris2 | Assignee: | Ankur Sinha (FranciscoD) <sanjay.ankur> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 26 | CC: | ferdnyc, hristo, sanjay.ankur | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | mpdris2-0.7-5.20171028git3c3fe12.fc27 mpdris2-0.7-5.20171028git3c3fe12.fc26 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-11-15 17:40:42 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1368911, 1507235 | ||||||
| Bug Blocks: | 1285816 | ||||||
| Attachments: |
|
||||||
|
Description
Iryna Shcherbina
2016-12-14 09:36:58 UTC
Thanks for the bug report. Looking into it. Created attachment 1233379 [details]
Switch to python 3
mpDris2 is fully compatible with python3 (don't forget to change shebang). But python3-mpd is not. mpDris 2 can use python-mpd2 instead (see #1368911) which is python 3 compatible.
Playing, pausing, prev/next seem to work.
Thanks for the patch. Applying it now. If we're going to switch to py3 and depend on python-mpd2, though, we're going to have to wait until the package is reviewed and accepted in Fedora. Otherwise mpdris ceases to function. :/ Everything is ready here: http://pkgs.fedoraproject.org/cgit/rpms/mpdris2.git/log/?h=python-mpd2 But I won't merge it to master until python-mpd2 is in Fedora :) This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. As I mentioned in bug 1368911, comment 5 this is no longer merely a nice-to-have, because (at least for me) mpDris2 is not functional using python-mpd in current python releases under Fedora 25. It breaks inside the mpd module code. Running /usr/bin/mpDris2 from mpdris2-0.7-2.20160422gita3af302.fc25.noarch under python3, with python3-mpd2 installed (from a locally-built package), functions perfectly with no changes. So, if there's any way to accelerate the acceptance of python-mpd2 into the repo, and then get mpDris2 updated to use python3, it would really be a help. Here's an F27 scratch build with python-mpd2 if anyone wants to test it out. Seems to work OK here :) here's a build for rawhide, now that python-mpd2 is available there: https://koji.fedoraproject.org/koji/buildinfo?buildID=992980 Testers welcome. I'll push updates to stable releases in a bit too. Cheers! mpdris2-0.7-5.20171028git3c3fe12.fc27 python-mpd2-0.5.5-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c mpdris2-0.7-5.20171028git3c3fe12.fc27 python-mpd2-0.5.5-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c mpdris2-0.7-5.20171028git3c3fe12.fc27, python-mpd2-0.5.5-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c mpdris2-0.7-5.20171028git3c3fe12.fc27 python-mpd2-0.5.5-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c mpdris2-0.7-5.20171028git3c3fe12.fc26 python-mpd2-0.5.5-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-865887c093 mpdris2-0.7-5.20171028git3c3fe12.fc26, python-mpd2-0.5.5-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-865887c093 mpdris2-0.7-5.20171028git3c3fe12.fc27, python-mpd2-0.5.5-4.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7cbd10475c mpdris2-0.7-5.20171028git3c3fe12.fc27, python-mpd2-0.5.5-4.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. mpdris2-0.7-5.20171028git3c3fe12.fc26, python-mpd2-0.5.5-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |