oops mistakenly set needinfo? this chromium rendering is not working good for me.

This package need to be updated as per latest python guidelines. I think you need to have this package packaged as similar to https://pnemade.fedorapeople.org/fedora-work/python-mpd2.spec

License also corrected to LGPLv3+

any updates here?

Heya,

This is blocking another update. 

Kushal - would you have time for this in the near future? Otherwise either Parag or I can package it up and the other can review it for the time being and then we can all co-maintain it? :)

Cheers!

This seems to have become a bit more urgent lately because, at least for me, mpDris2 is failing to connect to MPD using python-mpd. At various times, I was seeing crashes due to either system library argument formatting and/or pretty basic string-encoding issues:

  File "/usr/lib/python2.7/site-packages/mpd.py", line 316, in connect
    self._hello()
  File "/usr/lib/python2.7/site-packages/mpd.py", line 276, in _hello
    if not line.endswith("\n"):
TypeError: endswith first arg must be bytes or a tuple of bytes, not str

2017-07-01 07:23:08,409 mpDris2 ERROR: Could not connect to MPD: getaddrinfo() argument 2 must be integer or string

(The first one is because python-mpd doesn't set encoding="utf-8" on the network stream, as python-mpd2 does. The second one, I honestly didn't even begin to explore.)

Regardless, I built a python3-mpd2 of my own, installed it, and instantly by running 'python3 /usr/bin/mpDris2' full functionality was restored, with no changes required to the mpDris2 script.

Here's an updated spec/srpm:

https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2.spec
https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2-0.5.5-20170705git05510bb.fc26.src.rpm

- uses git sources
- builds docs and puts them in a different doc package
- skips tests because they require internet access
- various other updates to adhere to current packaging guidelines.

Kushal and I will co-maintain the package.

Cheers,
Ankur

Great to see movement on this, thanks Ankur!

(In reply to Ankur Sinha (FranciscoD) from comment #6)
> 
> https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2.spec

If I'm reading that right, wouldn't the python2 package still be built as 
python-mpd2-0.5.5-20170705git05510bb%{dist}.noarch.rpm, and merely offer python2-mpd2 as one of its Provides?

Wouldn't it be better to build the module packages as python2-mpd2 and python3-mpd2, respectively? See e.g. (as a random pick) python-tempdir.spec which does so:

https://src.fedoraproject.org/cgit/rpms/python-tempdir.git/tree/python-tempdir.spec

Something I also ended up doing when I built my own python-mpd2 RPMs (though I'm not sure if it's permissible under the Fedora packaging guidelines): Since python2-mpd2 is a drop-in replacement for python-mpd, might it maybe even make sense to have python2-mpd2 additionally Provides: python-mpd (and also Obsoletes:), instead of (or in addition to) Conflicting with it?

Then mpDris2 wouldn't _have_ to be repackaged in order to deploy python-mpd2, as it Requires: python-mpd. (I realize that the plan is to repackage mpDris2 anyway, of course, so changing its Requires is not a big deal. But in the interest of not breaking compatibility for people who may have various things installed...) *shrug* More an idle though that anything, which I realize isn't exactly what Bugzilla is meant for. So, feel free to ignore this tangent, and just focus on the package naming question.

Hi Kushal, Parag:

Since there hasn't been much activity on this recently, I'm going to close this review and submit a fresh one. Please feel free to comment on it if you'd like to co-maintain etc.

Thanks for the work you've already done on this :)

Frank, I'll update the spec in the new review ticket with your suggestions. Thanks for helping out :)

Ankur

*** This bug has been marked as a duplicate of bug 1507235 ***