Bug 1406068

Summary:	Do not log the expected actions as errors in installer log
Product:	Red Hat Satellite	Reporter:	sthirugn <sthirugn>
Component:	Upgrades	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED WONTFIX	QA Contact:	Katello QA List <katello-qa-list>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.2.6	CC:	bbuckingham, bkearney, inecas, mbacovsk, sthirugn
Target Milestone:	Unspecified
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-13 18:03:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1410795

Description sthirugn@redhat.com 2016-12-19 16:00:10 UTC

Description of problem:
Do not log the expected actions as errors in installer log

Version-Release number of selected component (if applicable):
Satellite 6.2.6

How reproducible:
Always

Steps to Reproduce:
1. Update Satellite from 6.2.5 to 6.2.6


Actual results:
# tail -f /var/log/foreman-installer/satellite.log
[ INFO 2016-12-19 10:03:24 main] Upgrade Step: remove_gutterball...
[ERROR 2016-12-19 10:03:24 main] package gutterball is not installed

[ INFO 2016-12-19 10:03:24 main] Upgrade Step: remove_event_queue...
[ INFO 2016-12-19 10:03:24 main] Event queue is already removed, skipping
[ INFO 2016-12-19 10:03:24 main] Upgrade completed!
[DEBUG 2016-12-19 10:03:24 main] Hook /usr/share/katello-installer-base/hooks/post/30-upgrade.rb returned [<Logging::Logger:0x12e46a8 name="main">, <Logging::Logger:0x12ea828 name="fatal">]
[ INFO 2016-12-19 10:03:24 main] All hooks in group post finished
[DEBUG 2016-12-19 10:03:24 main] Exit with status code: 2 (signal was 2)
[ERROR 2016-12-19 10:03:24 main] Errors encountered during run:
[ERROR 2016-12-19 10:03:24 main] package elasticsearch is not installed

[ERROR 2016-12-19 10:03:24 main] package gutterball is not installed

Expected results:
elasticsearch and gutterball are not supposed to be in 6.2.5.  Do not log them as errors.

Additional info:
This will create unnecessary confusion among the users making them think that the upgrade failed.

Comment 1 sthirugn@redhat.com 2016-12-19 16:05:14 UTC

Correction: The upgrade happened from 6.2.4 to 6.2.6

Comment 3 sthirugn@redhat.com 2016-12-19 16:12:49 UTC

Update: Good news - Rerunning `satellite-installer --scenario satellite --upgrade` on the already updated 6.2.6 does not show this error.

Comment 4 Brad Buckingham 2017-01-04 20:34:58 UTC

Hi Suresh,

Are the following statements correct?

 - upgrading from 6.2.z (e.g. 6.2.[1|2|3|4|5) to a later 6.2.z (e.g. 6.2.6) shows the error mentioned

 - upgrading from 6.2.z (e.g. 6.2.6) to the same 6.2.z (e.g. 6.2.6) does not show the error mentioned

Comment 5 sthirugn@redhat.com 2017-01-04 22:11:01 UTC

(In reply to Brad Buckingham from comment #4)
> Hi Suresh,
> 
> Are the following statements correct?
> 
>  - upgrading from 6.2.z (e.g. 6.2.[1|2|3|4|5) to a later 6.2.z (e.g. 6.2.6)
> shows the error mentioned
> 
>  - upgrading from 6.2.z (e.g. 6.2.6) to the same 6.2.z (e.g. 6.2.6) does not
> show the error mentioned

Yes you are right.  Recently (not sure in which release) we added a check to see if an upgrade step is already ran, if yes, it will not be run again in future.

Comment 6 Brad Buckingham 2017-01-04 23:22:31 UTC

Suresh, would this still be a valid bug then?  If the step is skipped on subsequent runs, I assume the error would no longer exist.

It looks like that change was introduced with bug 1264597 in 6.2.4.

Comment 7 sthirugn@redhat.com 2017-01-05 14:14:26 UTC

The error would still be shown when upgrading to 6.2.6 for the first time.  But, since there are no customer tickets on this, I am okay with closing this.

Comment 8 Bryan Kearney 2017-09-13 18:03:15 UTC

Closing per comment 7.