Description of problem: Do not log the expected actions as errors in installer log Version-Release number of selected component (if applicable): Satellite 6.2.6 How reproducible: Always Steps to Reproduce: 1. Update Satellite from 6.2.5 to 6.2.6 Actual results: # tail -f /var/log/foreman-installer/satellite.log [ INFO 2016-12-19 10:03:24 main] Upgrade Step: remove_gutterball... [ERROR 2016-12-19 10:03:24 main] package gutterball is not installed [ INFO 2016-12-19 10:03:24 main] Upgrade Step: remove_event_queue... [ INFO 2016-12-19 10:03:24 main] Event queue is already removed, skipping [ INFO 2016-12-19 10:03:24 main] Upgrade completed! [DEBUG 2016-12-19 10:03:24 main] Hook /usr/share/katello-installer-base/hooks/post/30-upgrade.rb returned [<Logging::Logger:0x12e46a8 name="main">, <Logging::Logger:0x12ea828 name="fatal">] [ INFO 2016-12-19 10:03:24 main] All hooks in group post finished [DEBUG 2016-12-19 10:03:24 main] Exit with status code: 2 (signal was 2) [ERROR 2016-12-19 10:03:24 main] Errors encountered during run: [ERROR 2016-12-19 10:03:24 main] package elasticsearch is not installed [ERROR 2016-12-19 10:03:24 main] package gutterball is not installed Expected results: elasticsearch and gutterball are not supposed to be in 6.2.5. Do not log them as errors. Additional info: This will create unnecessary confusion among the users making them think that the upgrade failed.
Correction: The upgrade happened from 6.2.4 to 6.2.6
Update: Good news - Rerunning `satellite-installer --scenario satellite --upgrade` on the already updated 6.2.6 does not show this error.
Hi Suresh, Are the following statements correct? - upgrading from 6.2.z (e.g. 6.2.[1|2|3|4|5) to a later 6.2.z (e.g. 6.2.6) shows the error mentioned - upgrading from 6.2.z (e.g. 6.2.6) to the same 6.2.z (e.g. 6.2.6) does not show the error mentioned
(In reply to Brad Buckingham from comment #4) > Hi Suresh, > > Are the following statements correct? > > - upgrading from 6.2.z (e.g. 6.2.[1|2|3|4|5) to a later 6.2.z (e.g. 6.2.6) > shows the error mentioned > > - upgrading from 6.2.z (e.g. 6.2.6) to the same 6.2.z (e.g. 6.2.6) does not > show the error mentioned Yes you are right. Recently (not sure in which release) we added a check to see if an upgrade step is already ran, if yes, it will not be run again in future.
Suresh, would this still be a valid bug then? If the step is skipped on subsequent runs, I assume the error would no longer exist. It looks like that change was introduced with bug 1264597 in 6.2.4.
The error would still be shown when upgrading to 6.2.6 for the first time. But, since there are no customer tickets on this, I am okay with closing this.
Closing per comment 7.