Bug 1406838

Summary:	memberOf fixup task does not validate args
Product:	Red Hat Enterprise Linux 7	Reporter:	mreynolds
Component:	389-ds-base	Assignee:	Noriko Hosoi <nhosoi>
Status:	CLOSED ERRATA	QA Contact:	Viktor Ashirov <vashirov>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	7.4	CC:	nkinder, rmeggins, sramling, vashirov
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	389-ds-base-1.3.6.1-3.el7	Doc Type:	Bug Fix
Doc Text:	Bug: If an invalid base dn, or invalid filter was provided in the memberof fixup task, there was no way to tell that the task actually failed. Fix: It was fixed to log an error and properly update the task status/exit code, when an error occurs.	Story Points:	---
Clone Of:	1406835	Environment:
Last Closed:	2017-08-01 21:12:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1406835
Bug Blocks:

Description mreynolds 2016-12-21 15:29:54 UTC

+++ This bug was initially created as a clone of Bug #1406835 +++

Description of problem:

The filter and basedn of the memberOf fixup task are not validated.  If there is a problem it silently fails, and it's not obvious in the logs that the task failed.

How reproducible:

Run the memberOf fixup task using an invalid filter:

    '(objectclass=person'


Actual results:

The errors log shows that the task finished, but in fact it failed


Expected results:

The errors log, and task log, show that the task failed to run.


Upstream ticket:

https://fedorahosted.org/389/ticket/49072

Comment 1 mreynolds 2016-12-21 15:44:13 UTC

Fixed upstream

Comment 4 Sankar Ramalingam 2017-05-25 05:48:24 UTC

Marking it as Verified based on upstream tests.
====================== test session starts ========================
platform linux2 -- Python 2.7.5, pytest-3.1.0, py-1.4.33, pluggy-0.4.0 -- /usr/bin/python
cachedir: .cache
metadata: {'Python': '2.7.5', 'Platform': 'Linux-3.10.0-663.el7.x86_64-x86_64-with-redhat-7.4-Maipo', 'Packages': {'py': '1.4.33', 'pytest': '3.1.0', 'pluggy': '0.4.0'}, 'Plugins': {'beakerlib': '0.7.1', 'html': '1.14.2', 'cov': '2.5.1', 'metadata': '1.5.0'}}
DS build: 1.3.6.1
389-ds-base: 1.3.6.1-15.el7
nss: 3.28.4-8.el7
nspr: 4.13.1-1.0.el7_3
openldap: 2.4.44-4.el7
svrcore: 4.1.3-2.el7

rootdir: /mnt/tests/rhds/tests/upstream/ds/dirsrvtests/tests/tickets, inifile:
plugins: metadata-1.5.0, html-1.14.2, cov-2.5.1, beakerlib-0.7.1
collected 2 items 

ticket49072_test.py::test_ticket49072_basedn PASSED
ticket49072_test.py::test_ticket49072_filter PASSED

=================== 2 passed in 26.45 seconds =====================

Comment 5 errata-xmlrpc 2017-08-01 21:12:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2086