Bug 1408494

Summary:	rhel-osp-director: [RFE] Need to add a check for the total count of the nodes - that it doesn't exceed the amount of available nodes in ironic.
Product:	Red Hat OpenStack	Reporter:	Alexander Chuzhoy <sasha>
Component:	python-tripleoclient	Assignee:	RHOS Maint <rhos-maint>
Status:	CLOSED EOL	QA Contact:	Gurenko Alex <agurenko>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	11.0 (Ocata)	CC:	apannu, beth.white, dbecker, dmacpher, emacchi, hbrock, jbuchta, jjoyce, jrist, jschluet, jslagle, jtomasek, mburns, morazi, rhel-osp-director-maint, slinaber, tvignaud, ukalifon
Target Milestone:	Upstream M2	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-ui-7.1.1-0.20170624213423.cb896fd.el7ost	Doc Type:	Enhancement
Doc Text:	This update changes the node selection UI elements to use a node picker/spinner to assign nodes to a role. In addition, this update provides a check to make sure the number of assigned nodes does not exceed the available nodes in OpenStack Bare Metal (ironic).	Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-24 12:56:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1469882

Description Alexander Chuzhoy 2016-12-23 19:10:15 UTC

rhel-osp-director:  [RFE]   Need to add a check for the total count of the nodes - that it doesn't exceed the amount of available nodes in ironic.

Environment:
puppet-ironic-9.4.1-1.el7ost.noarch
openstack-tripleo-heat-templates-5.1.0-7.el7ost.noarch
python-ironicclient-1.7.0-1.el7ost.noarch
openstack-ironic-api-6.2.2-2.el7ost.noarch
python-ironic-lib-2.1.1-2.el7ost.noarch
python-ironic-inspector-client-1.9.0-2.el7ost.noarch
instack-undercloud-5.1.0-4.el7ost.noarch
openstack-ironic-inspector-4.2.1-1.el7ost.noarch
openstack-ironic-conductor-6.2.2-2.el7ost.noarch
openstack-ironic-common-6.2.2-2.el7ost.noarch


I attempted a deployment with this amount of nodes:
  ControllerCount: 3
  ComputeCount: 2
  CephStorageCount: 3
  ServiceApiCount: 2

Total: 10

The amount of nodes in ironic:

ceph-0
ceph-1
serviceapi-0
serviceapi-1
controller-0
controller-1
controller-2
compute-0
compute-1

Total: 9

When I started the overcloud deployment - it proceeded until failed with:
2016-12-23 20:03:29Z [overcloud.Compute]: CREATE_FAILED  CREATE aborted
2016-12-23 20:03:30Z [overcloud]: CREATE_FAILED  Resource CREATE failed: ResourceInError: resources.CephStorage.resources[2].resources.CephStorage: Went to status ERROR due to "Message: No valid host was found. Th
ere are not enough hosts available., Code: 500"


Expected result:
The deployment shouldn't even start when the count of nodes per role in deployment exceeds the count of nodes with respective tag in ironic.

Comment 5 Jiri Tomasek 2017-05-31 11:42:14 UTC

UI now validates Node counts against count of ironic nodes available for deployment

Comment 6 Thierry Vignaud 2017-06-27 12:45:28 UTC

Can you add the gerrit id please so that we can check if we've the relevant change?
Thanks

Comment 8 Udi Kalifon 2017-11-20 17:03:53 UTC

Jiri, can you explain me what is the fix here? The GUI always allowed you to choose only up to the number of available nodes, so what's new here? I also think they meant to validate this in the templates, so that the CLI users will see a clear error soon when the deployment starts. This fix is only for the GUI, right? Thanks.

Comment 9 Jiri Tomasek 2017-11-27 11:50:52 UTC

The referenced patch links to the work which introduced changes in nodes tagging/assignment. It is referenced to ensure that these changes did retain the GUI behavior. So yes, that patch is only GUI related.

This RFE needs deploy_plan workflow in tripleo-common to validate the node counts.

Comment 10 Ola Pavlenko 2017-11-27 15:07:53 UTC

(In reply to Jiri Tomasek from comment #9)
> The referenced patch links to the work which introduced changes in nodes
> tagging/assignment. It is referenced to ensure that these changes did retain
> the GUI behavior. So yes, that patch is only GUI related.
> 
> This RFE needs deploy_plan workflow in tripleo-common to validate the node
> counts.

The intention of the request was adding functionality in CLI. 
The fix is partial, only in UI, CLI part is missing. 
Proposing to move the CLI part to Queens.