Bug 1409337
| Summary: | dvdauthor-0.7.2 is available | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Upstream Release Monitoring <upstream-release-monitoring> |
| Component: | dvdauthor | Assignee: | Richard Shaw <hobbes1069> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | hobbes1069, rdieter |
| Target Milestone: | --- | Keywords: | FutureFeature, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | dvdauthor-0.7.2-1.fc25 dvdauthor-0.7.2-1.fc24 dvdauthor-0.7.2-1.el7 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-11 07:23:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1409392 | ||
| Bug Blocks: | |||
|
Description
Upstream Release Monitoring
2017-01-01 00:12:32 UTC
0.7.2 is FTBFS, due to missing graphicsmagick related includes. src/Makefile ends up with MAGICK_CFLAGS = -I/usr/include/GraphicsMagick but as far as I can tell, that ends up not being used anywhere and src/Makefile.am only has
AM_CPPFLAGS = -DSYSCONFDIR="\"$(sysconfdir)\"" \
@XML_CPPFLAGS@ @MAGICK_CPPFLAGS@ @FREETYPE_CPPFLAGS@ @FRIBIDI_CFLAGS@ @FONTCONFIG_CFLAGS@
Regression comes from
https://github.com/ldo/dvdauthor/commit/940456212bb3b451294d2fa281c2b3ae757c20ad
ironically logged as:
"Fix inconsistency between MAGICK_CPPFLAGS being defined in configure,
and MAGICK_CFLAGS being used in Makefile."
So, options off the top of my head:
1 patching src/Makefile* to use @MAGICK_CFLAGS@ here
2 patch configure to query/set MAGICK_CPPFLAGS from pkgconfig too
or some other better idea.
Ok, trying patching Makefile.am and running autoreconf but I'm getting the following error in mock but not on a local build so I must be missing a package...
+ autoreconf -fi
configure.ac:136: warning: macro 'AM_ICONV' not found in library
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'autotools'.
libtoolize: copying file 'autotools/ltmain.sh'
libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac,
libtoolize: and rerunning libtoolize and aclocal.
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
configure.ac:136: warning: macro 'AM_ICONV' not found in library
configure.ac:136: error: possibly undefined macro: AM_ICONV
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
I have automake, autoconf, libtool, and gettext as build requirements so now I'm stumped.
Add BuildRequires: gettext-devel which provides /usr/share/aclocal/iconv.m4 that may help. That was it but it turns out there's an easier solution. The previous maintainer redirected MagickCore-config to /bin/true to trick configure but all I had to do was redirect it to GraphicsMagick-config and now the required include is used. dvdauthor-0.7.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-158c69aedd dvdauthor-0.7.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1d1f088eef dvdauthor-0.7.2-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7e4c2c0182 dvdauthor-0.7.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7e4c2c0182 dvdauthor-0.7.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1d1f088eef dvdauthor-0.7.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-158c69aedd dvdauthor-0.7.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. dvdauthor-0.7.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. dvdauthor-0.7.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |