Bug 1410699

Summary:	[geo-rep]: Config commands fail when the status is 'Created'
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	geo-replication	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	amukherj, bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1404678	Environment:
Last Closed:	2017-01-16 12:27:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1404678, 1410707
Bug Blocks:

Description Kotresh HR 2017-01-06 06:18:34 UTC

+++ This bug was initially created as a clone of Bug #1404678 +++

Description of problem:
Geo-replication config commands fail when geo-rep status is in 'Created'.
It fails with missing pid-file entry from the config file.

Version-Release number of selected component (if applicable):
master

How reproducible:
Always

Steps to Reproduce:
1. Create master volume and slave volume
2. Establish geo-rep between them. Do not start.
3. gluster vol geo-rep <mastervol> <slavehost>::<slavevol> config use_meta_volume true


Actual results:
The config command fails

Expected results:
The config command should not fail.

Comment 1 Worker Ant 2017-01-06 06:42:44 UTC

REVIEW: http://review.gluster.org/16342 (glusterd/geo-rep: Fix geo-rep config issue) posted (#1) for review on release-3.8 by Kotresh HR (khiremat)

Comment 2 Worker Ant 2017-01-06 07:40:29 UTC

REVIEW: http://review.gluster.org/16342 (glusterd/geo-rep: Fix geo-rep config issue) posted (#2) for review on release-3.8 by Kotresh HR (khiremat)

Comment 3 Worker Ant 2017-01-08 11:01:01 UTC

COMMIT: http://review.gluster.org/16342 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 11008e8b2a81a9b23d7a98e82db7a0ce0d9dbafb
Author: Kotresh HR <khiremat>
Date:   Wed Dec 14 07:03:28 2016 -0500

    glusterd/geo-rep: Fix geo-rep config issue
    
    Problem:
    Geo-replication config commands fail when geo-rep
    status is in 'Created'.
    
    Cause:
    During staging phase of geo-rep config, it checks
    for the existence of 'monitor.pid' file. But the
    pid file gets created only on start of geo-rep.
    Hence it fails.
    
    Fix:
    Do not check for the existence of pid-file during
    staging for config commands. It is not required.
    
    > Change-Id: I626d368b249cf0423c7f49b4284465508371f566
    > BUG: 1404678
    > Signed-off-by: Kotresh HR <khiremat>
    > Reviewed-on: http://review.gluster.org/16132
    > Smoke: Gluster Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Aravinda VK <avishwan>
    > Reviewed-by: Atin Mukherjee <amukherj>
    
    Change-Id: I626d368b249cf0423c7f49b4284465508371f566
    BUG: 1410699
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/16342
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Niels de Vos 2017-01-16 12:27:41 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.8, please open a new bug report.

glusterfs-3.8.8 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2017-January/000064.html
[2] https://www.gluster.org/pipermail/gluster-users/