Bug 1410711

Summary:	glusterd/geo-rep: geo-rep config command leaks fd
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	geo-replication	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1410708	Environment:
Last Closed:	2017-03-08 09:33:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1410708
Bug Blocks:

Description Kotresh HR 2017-01-06 07:53:47 UTC

+++ This bug was initially created as a clone of Bug #1410708 +++

Description of problem:
If geo-rep config is set when it is running, it will leak fd.

Version-Release number of selected component (if applicable):
3.8

How reproducible:
always

Steps to Reproduce:
1. Create gluster volumes and establish geo-rep session
2. Start geo-rep
3. Set any geo-rep config

Actual results:
fd should not be leaked

Expected results:
fd leaks

Additional info:
In master branch, the issue is fixed as part collection of patches went into
https://bugzilla.redhat.com/show_bug.cgi?id=1369124

Only backporting of the patch http://review.gluster.org/#/c/15263/ is required.

--- Additional comment from Worker Ant on 2017-01-06 02:40:32 EST ---

REVIEW: http://review.gluster.org/16344 (glusterd (geo-rep): fix unused variable warnings/errors) posted (#1) for review on release-3.8 by Kotresh HR (khiremat)

Comment 1 Worker Ant 2017-01-06 08:04:39 UTC

REVIEW: http://review.gluster.org/16345 (glusterd (geo-rep): fix unused variable warnings/errors) posted (#1) for review on release-3.9 by Kotresh HR (khiremat)

Comment 2 Worker Ant 2017-01-09 01:08:42 UTC

COMMIT: http://review.gluster.org/16345 committed in release-3.9 by Kaleb KEITHLEY (kkeithle) 
------
commit 1d6b261a68d0f2b3a60d8f6fea91b044cb94884e
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Mon Aug 22 13:22:02 2016 -0400

    glusterd (geo-rep): fix unused variable warnings/errors
    
    This patch fixes the fd leak when geo-rep config
    command is run while geo-rep is running.
    
    NOTE:
    The patch is backport of http://review.gluster.org/15263
    which was one of the collection of patches to fix the
    bug https://bugzilla.redhat.com/show_bug.cgi?id=1369124
    
    > Change-Id: I2edacd3d0f3924b1be0f0398ba9ac076459c5a61
    > BUG: 1369124
    > Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    > Reviewed-on: http://review.gluster.org/15263
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Saravanakumar Arumugam <sarumuga>
    
    Change-Id: I2edacd3d0f3924b1be0f0398ba9ac076459c5a61
    BUG: 1410711
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/16345
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Kaushal 2017-03-08 10:23:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/