Bug 1410924

Summary: [GSS](6.4.z) Incorrect JBOSS_HOME warning in vault.sh
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: dereed
Component: Scripts and CommandsAssignee: jboss-set
Status: CLOSED CURRENTRELEASE QA Contact: Peter Mackay <pmackay>
Severity: low Docs Contact:
Priority: low    
Version: 6.4.12CC: bmaxwell, fnasser, jondruse, pgier, pkremens, pmackay, rnetuka, rpelisse, rstancel
Target Milestone: CR1   
Target Release: EAP 6.4.20   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-19 12:42:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1510090    

Description dereed 2017-01-06 21:01:41 UTC
vault.sh has an incorrect check to make sure JBOSS_HOME is set correctly.

SANITIZED_JBOSS_HOME=`cd "$JBOSS_HOME/.."; pwd`
if [ "$RESOLVED_JBOSS" != "$SANITIZED_JBOSS_HOME" ]; then

The check will always fail because of the incorrect "/..", which should be removed.

The incorrect value is only used for printing the "WARNING JBOSS_HOME may be pointing to a different installation - unpredictable results may occur." log, and appears to have been around since at least EAP 6.0.

Comment 1 Romain Pelisse 2017-01-09 09:28:38 UTC
I will be working on a fix for upstream issue (WFCORE-2160/JBEAP-8135) - which most likely will be easy to backport into 6.4.x.

Comment 2 Romain Pelisse 2017-01-16 14:42:47 UTC
Pull Request: https://github.com/jbossas/jboss-eap/pull/2918

Comment 3 Ivo Hradek 2017-06-07 07:36:48 UTC
Verification failed for EAP-6.4.16-CP.CR1;

Similarly as in JBEAP-8154 / JBEAP-8135 there is undefined variable `$RESOLVED_JBOSS` (line 51), so the warning is still printed anyway.
Changing this to `$RESOLVED_JBOSS_HOME` (defined on line 45) should worked as expected.

Comment 6 Slavcho Stavrev 2017-06-14 12:46:02 UTC
PR: https://github.com/jbossas/jboss-eap/pull/3011

Comment 8 Jiří Bílek 2018-04-27 09:12:40 UTC
Regression tests passed
Verified with EAP 6.4.20.CP.CR1