Bug 1410991

Summary:	Review Request: rust-rpm-macros - RPM macros for building Rust packages on various architectures
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-24 19:24:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Igor Gnatenko 2017-01-07 09:26:09 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros-1-1.fc26.src.rpm
Description:
The package provides macros for building projects in Rust
on various architectures.
Fedora Account System Username: ignatenkobrain

Comment 1 Igor Gnatenko 2017-01-07 09:29:11 UTC

Note that we will split out rust and cargo macro out of this package.

Comment 2 Neal Gompa 2017-01-07 11:22:27 UTC

Taking this review.

Comment 3 Neal Gompa 2017-01-07 11:38:26 UTC

Review notes:

- Package is named properly
- Uses macros correctly
- Installs file properly
! Missing license file

This package is declared ASL 2.0 or MIT, which means we need a license file.

Comment 4 Igor Gnatenko 2017-01-24 15:43:03 UTC

Fixed, same URLs

Comment 5 Neal Gompa 2017-01-24 18:47:03 UTC

APPROVED.

Comment 6 Gwyn Ciesla 2017-01-24 19:14:12 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rust-rpm-macros

Comment 7 Igor Gnatenko 2017-01-24 19:24:08 UTC

okay, soon it will be in rawhide.