Bug 1410991 - Review Request: rust-rpm-macros - RPM macros for building Rust packages on various architectures
Summary: Review Request: rust-rpm-macros - RPM macros for building Rust packages on va...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-07 09:26 UTC by Igor Gnatenko
Modified: 2017-01-24 19:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-24 19:24:08 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Igor Gnatenko 2017-01-07 09:26:09 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros-1-1.fc26.src.rpm
Description:
The package provides macros for building projects in Rust
on various architectures.
Fedora Account System Username: ignatenkobrain
Comment 1 Igor Gnatenko 2017-01-07 09:29:11 UTC 
Note that we will split out rust and cargo macro out of this package.
Comment 2 Neal Gompa 2017-01-07 11:22:27 UTC 
Taking this review.
Comment 3 Neal Gompa 2017-01-07 11:38:26 UTC 
Review notes:

- Package is named properly
- Uses macros correctly
- Installs file properly
! Missing license file

This package is declared ASL 2.0 or MIT, which means we need a license file.
Comment 4 Igor Gnatenko 2017-01-24 15:43:03 UTC 
Fixed, same URLs
Comment 5 Neal Gompa 2017-01-24 18:47:03 UTC 
APPROVED.
Comment 6 Gwyn Ciesla 2017-01-24 19:14:12 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rust-rpm-macros
Comment 7 Igor Gnatenko 2017-01-24 19:24:08 UTC 
okay, soon it will be in rawhide.
Note You need to log in before you can comment on or make changes to this bug.