Bug 1411732
| Summary: | python3: conditional include of rewheel patch | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Felix Schwarz <fschwarz> |
| Component: | python3 | Assignee: | Charalampos Stratakis <cstratak> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | bkabrda, carl, cstratak, mcyprian, mhroncok, pviktori, rkuska, tomspur, torsava |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-10 21:18:58 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I pushed a commit to address that for python and python3 on all branches. Great - thank you :-) |
python3.spec contains: ... %if 0%{with_rewheel} Patch189: 00189-add-rewheel-module.patch %endif ... The packaging guideline says: "Packages MUST NOT have SourceN: or PatchN: tags which are conditionalized on architecture." (https://fedoraproject.org/wiki/Packaging:Guidelines#Conditionalizing_Builds_for_Architecture) Technically the current spec might not violate the guidelines (the guideline only refers to architecture-specific conditionals) but it seems wrong to me to exclude patches from the SRPM. Also it was pretty annoying for me when I rebuilt Python3 locally. Please always include the patch file (it won't be used if "with_rewheel" is 0 but at least one could use the same RPM to rebuild). If it helps I can provide a patch (though I guess you don't need help for such a trivial change).