Bug 1411732 - python3: conditional include of rewheel patch
Summary: python3: conditional include of rewheel patch
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python3 (Show other bugs)
(Show other bugs)
Version: rawhide
Hardware: Unspecified Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Charalampos Stratakis
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-10 11:58 UTC by Felix Schwarz
Modified: 2017-01-10 21:56 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-01-10 21:18:58 UTC
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description Felix Schwarz 2017-01-10 11:58:13 UTC
python3.spec contains:
...
%if 0%{with_rewheel}
Patch189: 00189-add-rewheel-module.patch
%endif
...

The packaging guideline says:
"Packages MUST NOT have SourceN: or PatchN: tags which are conditionalized on architecture."
(https://fedoraproject.org/wiki/Packaging:Guidelines#Conditionalizing_Builds_for_Architecture)

Technically the current spec might not violate the guidelines (the guideline only refers to architecture-specific conditionals) but it seems wrong to me to exclude patches from the SRPM. Also it was pretty annoying for me when I rebuilt Python3 locally.

Please always include the patch file (it won't be used if "with_rewheel" is 0 but at least one could use the same RPM to rebuild). If it helps I can provide a patch (though I guess you don't need help for such a trivial change).

Comment 1 Charalampos Stratakis 2017-01-10 21:18:58 UTC
I pushed a commit to address that for python and python3 on all branches.

Comment 2 Felix Schwarz 2017-01-10 21:56:05 UTC
Great - thank you :-)


Note You need to log in before you can comment on or make changes to this bug.