Bug 141373

Summary:	variables SYSLOGOPTS and NETLOGOPTS incorrectly referenced in /etc/rc.d/init.d/netdump
Product:	[Fedora] Fedora	Reporter:	bjorn l. <bl_fedora>
Component:	netdump	Assignee:	Neil Horman <nhorman>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	medium
Version:	3	CC:	jmoyer
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	0.7.14-1.2.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-06-26 16:40:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description bjorn l. 2004-11-30 19:01:09 UTC

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510

Description of problem:

In line 250:
   if [ -n $SYSLOGOPTS ] || [ -n $NETLOGOPTS ] ; then

always returns true.

You might have intended:
   if [ -n "$SYSLOGOPTS" ] || [ -n "$NETLOGOPTS" ] ; then

It's a minor issue, because the only side effect is that
the netconsole module is always loaded.  But if you wanted
that, the if statement is irrelevant.


Version-Release number of selected component (if applicable):
netdump-0.7.0-1

How reproducible:
Always

Steps to Reproduce:
1. Check the /etc/rc.d/init.d/netdump script
2.
3.
    

Additional info:

Comment 1 Dave Anderson 2004-11-30 20:07:12 UTC

Thanks...  

Also, if you set NETLOGADDR=NONE, you get the desired behaviour -- but
only because the unintended insmod of the netconsole module fails.

Comment 2 Neil Horman 2006-06-26 16:40:47 UTC

This is already fixed in furute versions of fedora and RHEL