Bug 141373 - variables SYSLOGOPTS and NETLOGOPTS incorrectly referenced in /etc/rc.d/init.d/netdump
variables SYSLOGOPTS and NETLOGOPTS incorrectly referenced in /etc/rc.d/init....
Product: Fedora
Classification: Fedora
Component: netdump (Show other bugs)
All Linux
medium Severity low
: ---
: ---
Assigned To: Neil Horman
Depends On:
  Show dependency treegraph
Reported: 2004-11-30 14:01 EST by bjorn l.
Modified: 2007-11-30 17:10 EST (History)
1 user (show)

See Also:
Fixed In Version: 0.7.14-1.2.1
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-06-26 12:40:47 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description bjorn l. 2004-11-30 14:01:09 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510

Description of problem:

In line 250:
   if [ -n $SYSLOGOPTS ] || [ -n $NETLOGOPTS ] ; then

always returns true.

You might have intended:
   if [ -n "$SYSLOGOPTS" ] || [ -n "$NETLOGOPTS" ] ; then

It's a minor issue, because the only side effect is that
the netconsole module is always loaded.  But if you wanted
that, the if statement is irrelevant.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Check the /etc/rc.d/init.d/netdump script

Additional info:
Comment 1 Dave Anderson 2004-11-30 15:07:12 EST

Also, if you set NETLOGADDR=NONE, you get the desired behaviour -- but
only because the unintended insmod of the netconsole module fails.

Comment 2 Neil Horman 2006-06-26 12:40:47 EDT
This is already fixed in furute versions of fedora and RHEL

Note You need to log in before you can comment on or make changes to this bug.