Bug 1415304
| Summary: | Overhaul .spec file | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Michal Bocek <mbocek> |
| Component: | preupgrade-assistant | Assignee: | Michal Bocek <mbocek> |
| Status: | CLOSED ERRATA | QA Contact: | Alois Mahdal <amahdal> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.9 | CC: | mbocek, ovasik, phracek |
| Target Milestone: | rc | Keywords: | Extras |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | preupgrade-assistant-2.3.0-1.el6 | Doc Type: | No Doc Update |
| Doc Text: |
undefined
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-03-21 12:11:01 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michal Bocek
2017-01-20 20:02:25 UTC
Fixed in upstream: https://github.com/upgrades-migrations/preupgrade-assistant/commit/9b1cb8738132d8d8beceed1dd31c3556fdb0f7d3 Are there any expected packaging changes in terms of the resulting (non-S)RPM? I guess none, but I'm not sure about the issue with %files section you mentioned. can you please elaborate bit on that? The update to %files section, as I mention in the description, has to do only with RPM metadata, if I'm not mistaken. Previously the %files section was listing certainly all the files, but not all the folder in which these files were - that had an effect that during the package uninstallation, such folders were left on the system. The division into preupgrade-assistant, preupgrade-assistant-tools, preupgrade-assistant-ui has been kept as it was. I guess by packaging changes you don't mean the content of the (S)RPM, i.e. what is to be installed. Because it so different now - many files were moved to another locations or renamed - these changes stem from BZ https://bugzilla.redhat.com/show_bug.cgi?id=1393080. (In reply to Michal Bocek from comment #5) > The update to %files section, as I mention in the description, has to do > only with RPM metadata, if I'm not mistaken. Previously the %files section > was listing certainly all the files, but not all the folder in which these > files were - that had an effect that during the package uninstallation, such > folders were left on the system. The directory ownership but it kinda belongs TPS domain; I'll see why it did not complain and/or see if there's something we can add to our suite. > I guess by packaging changes you don't mean the content of the (S)RPM, i.e. > what is to be installed. Because it so different now - many files were moved > to another locations or renamed - these changes stem from BZ > https://bugzilla.redhat.com/show_bug.cgi?id=1393080. Indeed, that was not what I meant, we expect that in any case. Thanks for the explanation. I'll treat it just as refactoring then; ie. we expect the same functionality as before, i.e. SanityOnly, i.e., if everything else passes, this can be marked as verified. Agree, the update can be perceived as refactoring. The functionality should remain the same. Notes for QA ============ This, along with bug 1393080 - project hierarchy cleanup, is refactoring and should be left among the last to verify. Once everything else is verified and test suite passes, these two bugs can be considered verified (SanityOnly). As of preupgrade-assistant-2.3.3-1.el6, test suite been ran and passed multiple times. No issues emerged relevant to the cleanup. I think we can safely close this now. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2017-0819.html |