In an effort to make the .spec file common for both RHEL 5 and RHEL 6, it needs to be revised extensively.
Some of the tasks to be done:
- Remove patches that are no longer needed.
- Make the spec more readable.
- Inspect Requires and Build Requires whether they still apply.
- Revise description texts.
- Fix issues with %files section (rpm should be able to report all files that were installed by Preupgrade Assistant).
- Analyze what parts of the current latest upstream code do not apply to RHEL 5 and add appropriate conditions to the spec.
Fixed in upstream: https://github.com/upgrades-migrations/preupgrade-assistant/commit/9b1cb8738132d8d8beceed1dd31c3556fdb0f7d3
Are there any expected packaging changes in terms of the resulting (non-S)RPM?
I guess none, but I'm not sure about the issue with %files section you mentioned. can you please elaborate bit on that?
The update to %files section, as I mention in the description, has to do only with RPM metadata, if I'm not mistaken. Previously the %files section was listing certainly all the files, but not all the folder in which these files were - that had an effect that during the package uninstallation, such folders were left on the system.
The division into preupgrade-assistant, preupgrade-assistant-tools, preupgrade-assistant-ui has been kept as it was.
I guess by packaging changes you don't mean the content of the (S)RPM, i.e. what is to be installed. Because it so different now - many files were moved to another locations or renamed - these changes stem from BZ https://bugzilla.redhat.com/show_bug.cgi?id=1393080.
(In reply to Michal Bocek from comment #5)
> The update to %files section, as I mention in the description, has to do
> only with RPM metadata, if I'm not mistaken. Previously the %files section
> was listing certainly all the files, but not all the folder in which these
> files were - that had an effect that during the package uninstallation, such
> folders were left on the system.
The directory ownership but it kinda belongs TPS domain; I'll see why it did not complain and/or see if there's something we can add to our suite.
> I guess by packaging changes you don't mean the content of the (S)RPM, i.e.
> what is to be installed. Because it so different now - many files were moved
> to another locations or renamed - these changes stem from BZ
Indeed, that was not what I meant, we expect that in any case. Thanks for the explanation.
I'll treat it just as refactoring then; ie. we expect the same functionality as before, i.e. SanityOnly, i.e., if everything else passes, this can be marked as verified.
Agree, the update can be perceived as refactoring. The functionality should remain the same.
Notes for QA
This, along with bug 1393080 - project hierarchy cleanup, is refactoring and should be left among the last to verify.
Once everything else is verified and test suite passes, these two bugs can be considered verified (SanityOnly).
As of preupgrade-assistant-2.3.3-1.el6, test suite been ran and passed multiple times. No issues emerged relevant to the cleanup.
I think we can safely close this now.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.