Bug 1415972

https://github.com/sosreport/sos/pull/906 been verified on osp10 manila

Created attachment 1249791 [details]
Result file which explains tha patch https://github.com/sosreport/sos/pull/906 been verified on osp10

(In reply to Anandprakash Tandale from comment #4)
> https://github.com/sosreport/sos/pull/906 been verified on osp10 manila

Thanks for the verification.

Upstream hasnt accepted the PR yet, theoretically there can be changes applied (I am not sure whats the upstream PR status, now). And definitely for "real QE work" I suggest verifying against RHEL7.4 RPM that will be available around devel freeze time.

(In reply to Pavel Moravec from comment #6)
> (In reply to Anandprakash Tandale from comment #4)
> > https://github.com/sosreport/sos/pull/906 been verified on osp10 manila
> 
> Thanks for the verification.
> 
> Upstream hasnt accepted the PR yet, theoretically there can be changes
> applied (I am not sure whats the upstream PR status, now). And definitely
> for "real QE work" I suggest verifying against RHEL7.4 RPM that will be
> available around devel freeze time.

Anand (or Poornima),
would you be able to do the verification on candidate RPM for 7.4, once available?

Our QE would appreciate it.

(In reply to Pavel Moravec from comment #7)
> (In reply to Pavel Moravec from comment #6)
> > (In reply to Anandprakash Tandale from comment #4)
> > > https://github.com/sosreport/sos/pull/906 been verified on osp10 manila
> > 
> > Thanks for the verification.
> > 
> > Upstream hasnt accepted the PR yet, theoretically there can be changes
> > applied (I am not sure whats the upstream PR status, now).

Hey pavel thanks for details 
Here is status of PR I have verified the output files, data and captured by this plugins with manila SME's they gave go green from manila side. So PR is waiting for bmr hand to move ahead.

> > for "real QE work" I suggest verifying against RHEL7.4 RPM that will be
> > available around devel freeze time.
> 
> Anand (or Poornima),
> would you be able to do the verification on candidate RPM for 7.4, once
> available?
> 
> Our QE would appreciate it.

Please share us details of candidate RPM for 7.4 once out over here.
If QE team has bandwidth they can test it.

POSTed to upstream as https://github.com/sosreport/sos/commit/60895a4c5ee363e1c457a16e731fc56851b1ded2

*** Bug 1438932 has been marked as a duplicate of this bug. ***

The business justification for this backport is that SOS reports are essential to Red Hat's support capability, which is itself central to our subscription business model.  Currently we are shipping Red Hat Open Stack Storage Platform version 10 with GA support status for manila with the NetApp backend.  But because the manila SOS plugin is not available for RHEL 7.3 and OSP10 uses RHEL 7.3 our support capability is currently crippled for manila.

Steve,
there is a 7.3 z-stream request (see some more background in bz1438932) for this RFE/Improvement. Could you please evaluate (business justification in $c14) and if you agree, add PMApproved to let it clone?

From devel perspective, backport shall be trivial.

Thanks.

(In reply to Poornima from comment #8)
> (In reply to Pavel Moravec from comment #7)
> > (In reply to Pavel Moravec from comment #6)
> > Anand (or Poornima),
> > would you be able to do the verification on candidate RPM for 7.4, once
> > available?
> > 
> > Our QE would appreciate it.
> 
> Please share us details of candidate RPM for 7.4 once out over here.
> If QE team has bandwidth they can test it.

Poornima,
See brew build https://brewweb.engineering.redhat.com/brew/rpminfo?rpmID=4647392 for OtherQE.

(In reply to Pavel Moravec from comment #19)
> (In reply to Poornima from comment #8)
> > (In reply to Pavel Moravec from comment #7)
> > > (In reply to Pavel Moravec from comment #6)
> > > Anand (or Poornima),
> > > would you be able to do the verification on candidate RPM for 7.4, once
> > > available?
> > > 
> > > Our QE would appreciate it.
> > 
> > Please share us details of candidate RPM for 7.4 once out over here.
> > If QE team has bandwidth they can test it.
> 
> Poornima,
> See brew build
> https://brewweb.engineering.redhat.com/brew/rpminfo?rpmID=4647392 for
> OtherQE.

Hello Poornima,
could you please verify this BZ against (updated/new) build:

https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=552080

or directly against package:

https://brewweb.engineering.redhat.com/brew/rpminfo?rpmID=4647392

?

Thanks in advance.

I can confirm that the plugin was added. If there is no positive feedback from the customer I will verify this SanityOnly.

# rpm -qf /usr/lib/python2.7/site-packages/sos/plugins/openstack_manila.py
sos-3.4-4.el7.noarch

# cat /usr/lib/python2.7/site-packages/sos/plugins/openstack_manila.py
. . .
    def setup(self):
        super(RedHatManila, self).setup()
        self.add_copy_spec("/etc/sudoers.d/manila")
. . .

I was able to install the sos-3.3-5.bz1415972.el7_3.noarch RPM on my OSP-11 system and I was able to run the SOS Report successfully. The generated tarball did contain correct data for the Manila logs and configuration files and no other plugin failed to generate their report. The only nit I have is that the description of the Manila SOS plugin needs a space between "OpenStack" and "Manila". Other than that, it looks great to me.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2203

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days