Bug 1417466

Summary:	Prevent reverse heal from happening
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1422942 1429312 (view as bug list)		Environment:
Last Closed:	2017-05-30 18:40:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1422942, 1429312

Description Pranith Kumar K 2017-01-29 16:21:02 UTC

Description of problem:
There is a chance for the source brick to go down just after
the new entry is created and before source brick is marked with
necessary pending markers. If after this any I/O happens then
new entry will become source and reverse heal will happen.
To prevent this mark the pending xattrs before creating the new
entry.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-01-29 16:25:49 UTC

REVIEW: https://review.gluster.org/16474 (cluster/afr: Perform new entry mark before creating new entry) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Worker Ant 2017-02-14 17:19:07 UTC

REVIEW: https://review.gluster.org/16474 (cluster/afr: Perform new entry mark before creating new entry) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Worker Ant 2017-02-16 15:24:34 UTC

COMMIT: https://review.gluster.org/16474 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 6588204568ab73bf8456ca3b2eccf2ae1182fb95
Author: Pranith Kumar K <pkarampu>
Date:   Mon Jan 23 14:58:45 2017 +0530

    cluster/afr: Perform new entry mark before creating new entry
    
    There is a chance for the source brick to go down just after
    the new entry is created and before source brick is marked with
    necessary pending markers. If after this any I/O happens then
    new entry will become source and reverse heal will happen.
    To prevent this mark the pending xattrs before creating the new
    entry.
    
    BUG: 1417466
    Change-Id: I233b87e694d32e5d734df5a83b4d2ca711c17503
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: https://review.gluster.org/16474
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Krutika Dhananjay <kdhananj>

Comment 4 Shyamsundar 2017-05-30 18:40:10 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/