Bug 1417495
| Summary: | Review Request: prelude-manager | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Andrejak <thomas.andrejak> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-22 14:49:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Thomas Andrejak
2017-01-30 00:12:04 UTC
This one also hangs in test-lock :(
Can you move %{?systemd_requires} next to the other "Requires:"? It's confusing to have it with "BuildRequires:".
Grammaro:
"This plugin authorize prelude-manager to log into XML files."
→ "This plugin allows prelude-manager to log into XML files."?
Really, logging into XML files, bleh ;)
I'd also drop the rest of the description in db-plugin, xml-plugin, devel, that just repeats the general description of prelude-manager.
In the service file:
> Description=Run prelude-manager
This will result in messages like "Starting Run prelude-manager" and "Stopping Run prelude-manager". Description should be something that fits in that template, e.g. Description=Prelude bus communicator.
OK, the daemon listens of 127.0.0.1 by default, seems reasonable.
+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ builds and installs OK
+ scriptlets are sane
+ R/BR/P look correct
+ fedora-review detects no issues
+ %check is present, and tests pass, except for one test
Package is APPROVED.
In the service file, also add Documentation=man:prelude-manager(1) . Thanks for the review Here are the new files : SPEC : https://fedorapeople.org/~totol/prelude-manager.spec SRPM : https://fedorapeople.org/~totol/prelude-manager-3.1.0-1.fc26.src.rpm Yep, look good. prelude-manager-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93 prelude-manager-3.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa prelude-manager-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93 prelude-manager-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa prelude-manager-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93 prelude-manager-3.1.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa prelude-manager-3.1.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-409ef6f707 prelude-manager-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93 prelude-manager-3.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-409ef6f707 prelude-manager-3.1.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa prelude-manager-3.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. prelude-manager-3.1.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. prelude-manager-3.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |