This is the continuation of #1386938 . This ticket is for prelude-manager, the bus communicator for Prelude modules and other IDMEF agents. Description in spec : Prelude Manager is the main program of the Prelude SIEM suite. It is a multithreaded server which handles connections from the Prelude modules. It is able to register local or remote agents, let the operator configure them remotely, receive alerts, and store alerts in a database or any format supported by reporting plugins, thus providing centralized logging and analysis. The IDMEF standard is used for alert representation. Support for filtering plugins allows you to hook in different places in the Manager to define custom criteria for alert logging. SPEC : https://fedorapeople.org/~totol/prelude-manager.spec SRPM : https://fedorapeople.org/~totol/prelude-manager-3.1.0-1.fc26.src.rpm Build : https://koji.fedoraproject.org/koji/taskinfo?taskID=17486670 About fedora review : prelude-manager.x86_64: W: spelling-error %description -l en_US multithreaded -> multicolored => False positive prelude-manager.x86_64: W: crypto-policy-non-compliance-gnutls-2 /usr/sbin/prelude-manager gnutls_priority_init => Fixed with patch, false positive prelude-manager.x86_64: W: non-ghost-in-run /run/prelude-manager => Guidelines https://fedoraproject.org/wiki/Packaging:Tmpfiles.d prelude-manager-db-plugin.x86_64: W: spelling-error %description -l en_US multithreaded -> multicolored => False positive prelude-manager-db-plugin.x86_64: W: no-documentation => prelude-manager-doc prelude-manager-xml-plugin.x86_64: W: spelling-error %description -l en_US multithreaded -> multicolored => False positive prelude-manager-xml-plugin.x86_64: W: no-documentation => prelude-manager-doc prelude-manager-devel.x86_64: W: spelling-error %description -l en_US multithreaded -> multicolored => False positive prelude-manager-devel.x86_64: W: no-documentation => prelude-manager-doc prelude-manager.src: W: spelling-error %description -l en_US multithreaded -> multicolored Thanks for the review Regards Thomas
This one also hangs in test-lock :( Can you move %{?systemd_requires} next to the other "Requires:"? It's confusing to have it with "BuildRequires:". Grammaro: "This plugin authorize prelude-manager to log into XML files." → "This plugin allows prelude-manager to log into XML files."? Really, logging into XML files, bleh ;) I'd also drop the rest of the description in db-plugin, xml-plugin, devel, that just repeats the general description of prelude-manager. In the service file: > Description=Run prelude-manager This will result in messages like "Starting Run prelude-manager" and "Stopping Run prelude-manager". Description should be something that fits in that template, e.g. Description=Prelude bus communicator. OK, the daemon listens of 127.0.0.1 by default, seems reasonable. + package name is OK + license is acceptable (GPLv2+) + license is specified correctly + builds and installs OK + scriptlets are sane + R/BR/P look correct + fedora-review detects no issues + %check is present, and tests pass, except for one test Package is APPROVED.
In the service file, also add Documentation=man:prelude-manager(1) .
Thanks for the review Here are the new files : SPEC : https://fedorapeople.org/~totol/prelude-manager.spec SRPM : https://fedorapeople.org/~totol/prelude-manager-3.1.0-1.fc26.src.rpm
Yep, look good.
prelude-manager-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93
prelude-manager-3.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa
prelude-manager-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93
prelude-manager-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa
prelude-manager-3.1.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa
prelude-manager-3.1.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-409ef6f707
prelude-manager-3.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-409ef6f707
prelude-manager-3.1.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa
prelude-manager-3.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
prelude-manager-3.1.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
prelude-manager-3.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.