Bug 1418369

Summary:	Need way to revert commits or mark tests bad without testing
Product:	[Community] GlusterFS	Reporter:	Jeff Darcy <jdarcy>
Component:	project-infrastructure	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-infra, jdarcy, jeff, ndevos, nigelb
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-17 05:46:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff Darcy 2017-02-01 16:30:57 UTC

As discussed in today's community meeting, we need a way to "dig ourselves out of the hole" quickly when work is blocked by sporadically failing tests.  Specifically, there should be a way to exempt patches from testing which (a) revert a previous commit or (b) mark a test as bad.  Gerrit has permissions that allow specified users to bypass tests by pushing to refs/heads/xxx instead of refs/for/xxx.  This permission should be enabled for project architects (and probably not for others).  If we can further extend or limit this ability by recognizing reverts and test markings for what they are, that's great but not immediately necessary.

Comment 1 Niels de Vos 2017-02-14 12:11:28 UTC

Should we not have a discussion or at least a notification about this on the maintainers list? I think permissions to push changes without reviews can be done by release managers (because they need to be able to push tags?), but fine-tuning the permissions sounds like a good idea.

Just some guidelines or recommendations on which changes to push and 'rules' to notify relevant persons and track progress would be good.

Comment 2 Jeff Darcy 2017-02-14 12:23:22 UTC

Yes, there should be a policy discussion about this, but it's moot if the technical capability isn't implemented.  Therefore, I think the two efforts can proceed in parallel.

Comment 3 Nigel Babu 2017-04-17 05:46:53 UTC

The technical capability is now done. There's a team called gluster-plumbers who have permission to push to any branch directly. It has Vijay, Jeff, and Shyam. As far as infra is concerned this is fixed. If the policy dictates changes to this, please file a bug.