Bug 1420457

Summary:	firewall-cmd set-log-denied may fail with ALREADY_SET
Product:	Red Hat Enterprise Linux 7	Reporter:	Tomas Dolezal <todoleza>
Component:	firewalld	Assignee:	Thomas Woerner <twoerner>
Status:	CLOSED ERRATA	QA Contact:	Tomas Dolezal <todoleza>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.3	CC:	todoleza
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 16:22:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	845257, 1366654, 1414584
Bug Blocks:

Description Tomas Dolezal 2017-02-08 17:22:10 UTC

Description of problem:
ALREADY_ENABLED was changed to return sucess (0) exitcode. this is not the case for repeated --set-log-denied argument

Version-Release number of selected component (if applicable):
firewalld-0.4.4.2-2.fc24.noarch
firewalld-0.4.3.2-8.el7_3.noarch

How reproducible:
always

Steps to Reproduce:
firewall-cmd --set-log-denied off; firewall-cmd --set-log-denied off

Actual results:
Error: ALREADY_SET: off

with EC=34

Expected results:
Warning: ALREADY_set off

with EC=0
Additional info:

Comment 3 Thomas Woerner 2017-02-09 17:41:18 UTC

Fixed upstream:
https://github.com/t-woerner/firewalld/commit/742133120bdbd199f84efe38555bc78771a8c077
https://github.com/t-woerner/firewalld/commit/c15bc37282b2724170a14071bfade7d1b189e3dd
https://github.com/t-woerner/firewalld/commit/3d97abbbb2e608242bda6a500cdc0b65deed5cf0

Comment 6 errata-xmlrpc 2017-08-01 16:22:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1934