Bug 142099

Summary: missing expression in return statement
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: NetworkManagerAssignee: Dan Williams <dcbw>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-01-29 22:13:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2004-12-07 10:40:03 UTC
Description of problem:

I just tried to compile package NetworkManager-0.3.1-3 from 
Redhat Fedora Core 3.

The compiler said

NMWirelessAppletDbus.c(853): warning #117: non-void function
"nmwa_dbus_update_active_device_strength" should return a value

The source code is

static gboolean nmwa_dbus_update_active_device_strength (gpointer
user_data)
{
        NMWirelessApplet *applet;

        g_return_if_fail (user_data != NULL);

I agree with the compiler. This code would benefit from re-work to ensure
that this non-void function does return a value.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Dan Williams 2005-01-29 22:13:10 UTC
Should be fixed.  Thanks.