Bug 1421066 (deepin-wm-switcher)

Summary:	Review Request: deepin-wm-switcher - Window manager switcher for Deepin
Product:	[Fedora] Fedora	Reporter:	sensor.wen
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-07-22 13:32:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1421058
Bug Blocks:	1465889

Description sensor.wen 2017-02-10 09:32:17 UTC

Spec URL: https://github.com/FZUG/repo/blob/master/rpms/deepin_project/deepin-wm-switcher.spec

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00501859-deepin-wm-switcher/deepin-wm-switcher-1.1.0-1.git8692ad3.fc25.src.rpm

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17617894

Description: Window manager switcher for Deepin

Fedora Account System Username: mosquito

Comment 1 sensor.wen 2017-08-03 08:23:30 UTC

SPEC:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585991-deepin-wm-switcher/deepin-wm-switcher.spec
SRPM:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585991-deepin-wm-switcher/deepin-wm-switcher-1.1.2-1.fc25.src.rpm

Release 1.1.2

Comment 2 Zbigniew Jędrzejewski-Szmek 2017-08-03 14:21:13 UTC

It would be better to include some additional info in %description about what this package actually *does*. The text from https://github.com/linuxdeepin/deepin-wm-switcher#deepin-wm-switcher would be OK, I think.

Looks OK, but #1421058 needs to be done first to meaningfully review this.

Comment 3 sensor.wen 2017-10-10 16:33:41 UTC

#1421058 is done. let's go review it. @Zbigniew Jędrzejewski-Szmek

Comment 4 sensor.wen 2017-10-10 16:48:14 UTC

https://koji.fedoraproject.org/koji/taskinfo?taskID=22368478

Comment 5 Zbigniew Jędrzejewski-Szmek 2017-10-11 10:33:05 UTC

+ package name is OK
+ license is acceptable for Fedora (GPLv3)
+ license is specified correctly
+ package builds in mock
+ BuildRequires / Requires / Provides look OK
+ latest version
+ fedora-review finds no issues
+ rpmlint output is OK (only some grumbling about missing man pages and documentation)
+ no scriptlets are necessary

Package is APPROVED. I didn't test it, but the packaging is OK.

Comment 6 Gwyn Ciesla 2017-10-11 12:53:02 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-wm-switcher

Comment 7 Zamir SUN 2018-07-22 13:32:47 UTC

This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.

Comment 8 Zamir SUN 2018-07-22 13:33:23 UTC

This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.